Bitcoin Core 32.99.0
P2P Digital Currency
transaction_tests.cpp
Go to the documentation of this file.
1// Copyright (c) 2011-present The Bitcoin Core developers
2// Distributed under the MIT software license, see the accompanying
3// file COPYING or http://www.opensource.org/licenses/mit-license.php.
4
5#include <test/data/tx_invalid.json.h>
6#include <test/data/tx_valid.json.h>
8
9#include <chain.h>
10#include <checkqueue.h>
11#include <clientversion.h>
12#include <consensus/amount.h>
13#include <consensus/consensus.h>
14#include <consensus/tx_check.h>
15#include <consensus/tx_verify.h>
17#include <core_io.h>
18#include <key.h>
19#include <policy/policy.h>
20#include <policy/settings.h>
22#include <script/interpreter.h>
23#include <script/script.h>
24#include <script/script_error.h>
25#include <script/sigcache.h>
26#include <script/sign.h>
28#include <script/solver.h>
29#include <streams.h>
30#include <test/util/common.h>
31#include <test/util/json.h>
32#include <test/util/random.h>
33#include <test/util/script.h>
35#include <util/strencodings.h>
36#include <util/string.h>
37#include <validation.h>
38
39#include <functional>
40#include <map>
41#include <string>
42
43#include <boost/test/unit_test.hpp>
44
45#include <univalue.h>
46
47using namespace util::hex_literals;
49using util::ToString;
50
51typedef std::vector<unsigned char> valtype;
52
55
56static const std::map<std::string, script_verify_flag_name>& mapFlagNames = ScriptFlagNamesToEnum();
57
59{
61 if (strFlags.empty() || strFlags == "NONE") return flags;
62
63 std::vector<std::string> words = SplitString(strFlags, ',');
64 for (const std::string& word : words)
65 {
66 if (!mapFlagNames.contains(word)) {
67 BOOST_ERROR("Bad test: unknown verification flag '" << word << "'");
68 continue;
69 }
70 flags |= mapFlagNames.at(word);
71 }
72 return flags;
73}
74
75// Check that all flags in STANDARD_SCRIPT_VERIFY_FLAGS are present in mapFlagNames.
77{
79 for (const auto& pair : mapFlagNames) {
80 standard_flags_missing &= ~(pair.second);
81 }
82 return standard_flags_missing == 0;
83}
84
85/*
86* Check that the input scripts of a transaction are valid/invalid as expected.
87*/
88bool CheckTxScripts(const CTransaction& tx, const std::map<COutPoint, CScript>& map_prevout_scriptPubKeys,
89 const std::map<COutPoint, int64_t>& map_prevout_values, script_verify_flags flags,
90 const PrecomputedTransactionData& txdata, const std::string& strTest, bool expect_valid)
91{
92 bool tx_valid = true;
94 for (unsigned int i = 0; i < tx.vin.size() && tx_valid; ++i) {
95 const CTxIn input = tx.vin[i];
96 const CAmount amount = map_prevout_values.contains(input.prevout) ? map_prevout_values.at(input.prevout) : 0;
97 try {
98 tx_valid = VerifyScript(input.scriptSig, map_prevout_scriptPubKeys.at(input.prevout),
100 } catch (...) {
101 BOOST_ERROR("Bad test: " << strTest);
102 return true; // The test format is bad and an error is thrown. Return true to silence further error.
103 }
104 if (expect_valid) {
105 BOOST_CHECK_MESSAGE(tx_valid, strTest);
106 BOOST_CHECK_MESSAGE((err == SCRIPT_ERR_OK), ScriptErrorString(err));
108 }
109 }
110 if (!expect_valid) {
111 BOOST_CHECK_MESSAGE(!tx_valid, strTest);
112 BOOST_CHECK_MESSAGE((err != SCRIPT_ERR_OK), ScriptErrorString(err));
113 }
114 return (tx_valid == expect_valid);
115}
116
117/*
118 * Trim or fill flags to make the combination valid:
119 * WITNESS must be used with P2SH
120 * CLEANSTACK must be used WITNESS and P2SH
121 */
122
124{
125 // WITNESS requires P2SH
126 if (!(flags & SCRIPT_VERIFY_P2SH)) flags &= ~SCRIPT_VERIFY_WITNESS;
127
128 // CLEANSTACK requires WITNESS (and transitively CLEANSTACK requires P2SH)
129 if (!(flags & SCRIPT_VERIFY_WITNESS)) flags &= ~SCRIPT_VERIFY_CLEANSTACK;
131 return flags;
132}
133
135{
136 // CLEANSTACK implies WITNESS
138
139 // WITNESS implies P2SH (and transitively CLEANSTACK implies P2SH)
142 return flags;
143}
144
145// Exclude each possible script verify flag from flags. Returns a set of these flag combinations
146// that are valid and without duplicates. For example: if flags=1111 and the 4 possible flags are
147// 0001, 0010, 0100, and 1000, this should return the set {0111, 1011, 1101, 1110}.
148// Assumes that mapFlagNames contains all script verify flags.
150{
151 std::set<script_verify_flags> flags_combos;
152 for (const auto& pair : mapFlagNames) {
153 script_verify_flags flags_excluding_one = TrimFlags(flags & ~(pair.second));
154 if (flags != flags_excluding_one) {
155 flags_combos.insert(flags_excluding_one);
156 }
157 }
158 return flags_combos;
159}
160
162
164{
165 BOOST_CHECK_MESSAGE(CheckMapFlagNames(), "mapFlagNames is missing a script verification flag");
166 // Read tests from test/data/tx_valid.json
167 UniValue tests = read_json(json_tests::tx_valid);
168
169 for (unsigned int idx = 0; idx < tests.size(); idx++) {
170 const UniValue& test = tests[idx];
171 std::string strTest = test.write();
172 if (test[0].isArray())
173 {
174 if (test.size() != 3 || !test[1].isStr() || !test[2].isStr())
175 {
176 BOOST_ERROR("Bad test: " << strTest);
177 continue;
178 }
179
180 std::map<COutPoint, CScript> mapprevOutScriptPubKeys;
181 std::map<COutPoint, int64_t> mapprevOutValues;
182 UniValue inputs = test[0].get_array();
183 bool fValid = true;
184 for (unsigned int inpIdx = 0; inpIdx < inputs.size(); inpIdx++) {
185 const UniValue& input = inputs[inpIdx];
186 if (!input.isArray()) {
187 fValid = false;
188 break;
189 }
190 const UniValue& vinput = input.get_array();
191 if (vinput.size() < 3 || vinput.size() > 4)
192 {
193 fValid = false;
194 break;
195 }
196 COutPoint outpoint{Txid::FromHex(vinput[0].get_str()).value(), uint32_t(vinput[1].getInt<int>())};
197 mapprevOutScriptPubKeys[outpoint] = ParseScript(vinput[2].get_str());
198 if (vinput.size() >= 4)
199 {
200 mapprevOutValues[outpoint] = vinput[3].getInt<int64_t>();
201 }
202 }
203 if (!fValid)
204 {
205 BOOST_ERROR("Bad test: " << strTest);
206 continue;
207 }
208
209 std::string transaction = test[1].get_str();
210 DataStream stream(ParseHex(transaction));
212
213 TxValidationState state;
214 BOOST_CHECK_MESSAGE(CheckTransaction(tx, state), strTest);
215 BOOST_CHECK(state.IsValid());
216
218 script_verify_flags verify_flags = ParseScriptFlags(test[2].get_str());
219
220 // Check that the test gives a valid combination of flags (otherwise VerifyScript will throw). Don't edit the flags.
221 if (~verify_flags != FillFlags(~verify_flags)) {
222 BOOST_ERROR("Bad test flags: " << strTest);
223 }
224
225 BOOST_CHECK_MESSAGE(CheckTxScripts(tx, mapprevOutScriptPubKeys, mapprevOutValues, ~verify_flags, txdata, strTest, /*expect_valid=*/true),
226 "Tx unexpectedly failed: " << strTest);
227
228 // Backwards compatibility of script verification flags: Removing any flag(s) should not invalidate a valid transaction
229 for (const auto& [name, flag] : mapFlagNames) {
230 // Removing individual flags
231 script_verify_flags flags = TrimFlags(~(verify_flags | flag));
232 if (!CheckTxScripts(tx, mapprevOutScriptPubKeys, mapprevOutValues, flags, txdata, strTest, /*expect_valid=*/true)) {
233 BOOST_ERROR("Tx unexpectedly failed with flag " << name << " unset: " << strTest);
234 }
235 // Removing random combinations of flags
237 if (!CheckTxScripts(tx, mapprevOutScriptPubKeys, mapprevOutValues, flags, txdata, strTest, /*expect_valid=*/true)) {
238 BOOST_ERROR("Tx unexpectedly failed with random flags " << ToString(flags.as_int()) << ": " << strTest);
239 }
240 }
241
242 // Check that flags are maximal: transaction should fail if any unset flags are set.
243 for (auto flags_excluding_one : ExcludeIndividualFlags(verify_flags)) {
244 if (!CheckTxScripts(tx, mapprevOutScriptPubKeys, mapprevOutValues, ~flags_excluding_one, txdata, strTest, /*expect_valid=*/false)) {
245 BOOST_ERROR("Too many flags unset: " << strTest);
246 }
247 }
248 }
249 }
250}
251
253{
254 // Read tests from test/data/tx_invalid.json
255 UniValue tests = read_json(json_tests::tx_invalid);
256
257 for (unsigned int idx = 0; idx < tests.size(); idx++) {
258 const UniValue& test = tests[idx];
259 std::string strTest = test.write();
260 if (test[0].isArray())
261 {
262 if (test.size() != 3 || !test[1].isStr() || !test[2].isStr())
263 {
264 BOOST_ERROR("Bad test: " << strTest);
265 continue;
266 }
267
268 std::map<COutPoint, CScript> mapprevOutScriptPubKeys;
269 std::map<COutPoint, int64_t> mapprevOutValues;
270 UniValue inputs = test[0].get_array();
271 bool fValid = true;
272 for (unsigned int inpIdx = 0; inpIdx < inputs.size(); inpIdx++) {
273 const UniValue& input = inputs[inpIdx];
274 if (!input.isArray()) {
275 fValid = false;
276 break;
277 }
278 const UniValue& vinput = input.get_array();
279 if (vinput.size() < 3 || vinput.size() > 4)
280 {
281 fValid = false;
282 break;
283 }
284 COutPoint outpoint{Txid::FromHex(vinput[0].get_str()).value(), uint32_t(vinput[1].getInt<int>())};
285 mapprevOutScriptPubKeys[outpoint] = ParseScript(vinput[2].get_str());
286 if (vinput.size() >= 4)
287 {
288 mapprevOutValues[outpoint] = vinput[3].getInt<int64_t>();
289 }
290 }
291 if (!fValid)
292 {
293 BOOST_ERROR("Bad test: " << strTest);
294 continue;
295 }
296
297 std::string transaction = test[1].get_str();
298 DataStream stream(ParseHex(transaction));
300
301 TxValidationState state;
302 if (!CheckTransaction(tx, state) || state.IsInvalid()) {
303 BOOST_CHECK_MESSAGE(test[2].get_str() == "BADTX", strTest);
304 continue;
305 }
306
308 script_verify_flags verify_flags = ParseScriptFlags(test[2].get_str());
309
310 // Check that the test gives a valid combination of flags (otherwise VerifyScript will throw). Don't edit the flags.
311 if (verify_flags != FillFlags(verify_flags)) {
312 BOOST_ERROR("Bad test flags: " << strTest);
313 }
314
315 // Not using FillFlags() in the main test, in order to detect invalid verifyFlags combination
316 BOOST_CHECK_MESSAGE(CheckTxScripts(tx, mapprevOutScriptPubKeys, mapprevOutValues, verify_flags, txdata, strTest, /*expect_valid=*/false),
317 "Tx unexpectedly passed: " << strTest);
318
319 // Backwards compatibility of script verification flags: Adding any flag(s) should not validate an invalid transaction
320 for (const auto& [name, flag] : mapFlagNames) {
321 script_verify_flags flags = FillFlags(verify_flags | flag);
322 // Adding individual flags
323 if (!CheckTxScripts(tx, mapprevOutScriptPubKeys, mapprevOutValues, flags, txdata, strTest, /*expect_valid=*/false)) {
324 BOOST_ERROR("Tx unexpectedly passed with flag " << name << " set: " << strTest);
325 }
326 // Adding random combinations of flags
328 if (!CheckTxScripts(tx, mapprevOutScriptPubKeys, mapprevOutValues, flags, txdata, strTest, /*expect_valid=*/false)) {
329 BOOST_ERROR("Tx unexpectedly passed with random flags " << name << ": " << strTest);
330 }
331 }
332
333 // Check that flags are minimal: transaction should succeed if any set flags are unset.
334 for (auto flags_excluding_one : ExcludeIndividualFlags(verify_flags)) {
335 if (!CheckTxScripts(tx, mapprevOutScriptPubKeys, mapprevOutValues, flags_excluding_one, txdata, strTest, /*expect_valid=*/true)) {
336 BOOST_ERROR("Too many flags set: " << strTest);
337 }
338 }
339 }
340 }
341}
342
344{
346
347 TxValidationState state;
348 BOOST_CHECK_MESSAGE(!CheckTransaction(CTransaction(empty), state), "Transaction with no inputs should be invalid.");
349 BOOST_CHECK(state.GetRejectReason() == "bad-txns-vin-empty");
350}
351
353{
354 auto createTransaction =[](size_t payloadSize) {
356 tx.vin.resize(1);
357 tx.vout.emplace_back(1, CScript() << OP_RETURN << std::vector<unsigned char>(payloadSize));
358 return CTransaction(tx);
359 };
360 const auto maxTransactionSize = MAX_BLOCK_WEIGHT / WITNESS_SCALE_FACTOR;
361 const auto oversizedTransactionBaseSize = ::GetSerializeSize(TX_NO_WITNESS(createTransaction(maxTransactionSize))) - maxTransactionSize;
362
363 auto maxPayloadSize = maxTransactionSize - oversizedTransactionBaseSize;
364 {
365 TxValidationState state;
366 CheckTransaction(createTransaction(maxPayloadSize), state);
367 BOOST_CHECK(state.GetRejectReason() != "bad-txns-oversize");
368 }
369
370 maxPayloadSize += 1;
371 {
372 TxValidationState state;
373 BOOST_CHECK_MESSAGE(!CheckTransaction(createTransaction(maxPayloadSize), state), "Oversized transaction should be invalid");
374 BOOST_CHECK(state.GetRejectReason() == "bad-txns-oversize");
375 }
376}
377
378BOOST_AUTO_TEST_CASE(basic_transaction_tests)
379{
380 // Random real transaction (e2769b09e784f32f62ef849763d4f45b98e07ba658647343b915ff832b110436)
381 unsigned char ch[] = {0x01, 0x00, 0x00, 0x00, 0x01, 0x6b, 0xff, 0x7f, 0xcd, 0x4f, 0x85, 0x65, 0xef, 0x40, 0x6d, 0xd5, 0xd6, 0x3d, 0x4f, 0xf9, 0x4f, 0x31, 0x8f, 0xe8, 0x20, 0x27, 0xfd, 0x4d, 0xc4, 0x51, 0xb0, 0x44, 0x74, 0x01, 0x9f, 0x74, 0xb4, 0x00, 0x00, 0x00, 0x00, 0x8c, 0x49, 0x30, 0x46, 0x02, 0x21, 0x00, 0xda, 0x0d, 0xc6, 0xae, 0xce, 0xfe, 0x1e, 0x06, 0xef, 0xdf, 0x05, 0x77, 0x37, 0x57, 0xde, 0xb1, 0x68, 0x82, 0x09, 0x30, 0xe3, 0xb0, 0xd0, 0x3f, 0x46, 0xf5, 0xfc, 0xf1, 0x50, 0xbf, 0x99, 0x0c, 0x02, 0x21, 0x00, 0xd2, 0x5b, 0x5c, 0x87, 0x04, 0x00, 0x76, 0xe4, 0xf2, 0x53, 0xf8, 0x26, 0x2e, 0x76, 0x3e, 0x2d, 0xd5, 0x1e, 0x7f, 0xf0, 0xbe, 0x15, 0x77, 0x27, 0xc4, 0xbc, 0x42, 0x80, 0x7f, 0x17, 0xbd, 0x39, 0x01, 0x41, 0x04, 0xe6, 0xc2, 0x6e, 0xf6, 0x7d, 0xc6, 0x10, 0xd2, 0xcd, 0x19, 0x24, 0x84, 0x78, 0x9a, 0x6c, 0xf9, 0xae, 0xa9, 0x93, 0x0b, 0x94, 0x4b, 0x7e, 0x2d, 0xb5, 0x34, 0x2b, 0x9d, 0x9e, 0x5b, 0x9f, 0xf7, 0x9a, 0xff, 0x9a, 0x2e, 0xe1, 0x97, 0x8d, 0xd7, 0xfd, 0x01, 0xdf, 0xc5, 0x22, 0xee, 0x02, 0x28, 0x3d, 0x3b, 0x06, 0xa9, 0xd0, 0x3a, 0xcf, 0x80, 0x96, 0x96, 0x8d, 0x7d, 0xbb, 0x0f, 0x91, 0x78, 0xff, 0xff, 0xff, 0xff, 0x02, 0x8b, 0xa7, 0x94, 0x0e, 0x00, 0x00, 0x00, 0x00, 0x19, 0x76, 0xa9, 0x14, 0xba, 0xde, 0xec, 0xfd, 0xef, 0x05, 0x07, 0x24, 0x7f, 0xc8, 0xf7, 0x42, 0x41, 0xd7, 0x3b, 0xc0, 0x39, 0x97, 0x2d, 0x7b, 0x88, 0xac, 0x40, 0x94, 0xa8, 0x02, 0x00, 0x00, 0x00, 0x00, 0x19, 0x76, 0xa9, 0x14, 0xc1, 0x09, 0x32, 0x48, 0x3f, 0xec, 0x93, 0xed, 0x51, 0xf5, 0xfe, 0x95, 0xe7, 0x25, 0x59, 0xf2, 0xcc, 0x70, 0x43, 0xf9, 0x88, 0xac, 0x00, 0x00, 0x00, 0x00, 0x00};
382 std::vector<unsigned char> vch(ch, ch + sizeof(ch) -1);
384 SpanReader{vch} >> TX_WITH_WITNESS(tx);
385 TxValidationState state;
386 BOOST_CHECK_MESSAGE(CheckTransaction(CTransaction(tx), state), "Simple deserialized transaction should be valid.");
387 BOOST_CHECK_MESSAGE(state.IsValid(), "Simple deserialized transaction should be valid.");
388
389 // Check that duplicate txins fail
390 tx.vin.push_back(tx.vin[0]);
391 BOOST_CHECK_MESSAGE(!CheckTransaction(CTransaction(tx), state) || !state.IsValid(), "Transaction with duplicate txins should be invalid.");
392}
393
395{
398 std::vector<CMutableTransaction> dummyTransactions =
399 SetupDummyInputs(keystore, coins, {11*CENT, 50*CENT, 21*CENT, 22*CENT});
400
402 t1.vin.resize(3);
403 t1.vin[0].prevout.hash = dummyTransactions[0].GetHash();
404 t1.vin[0].prevout.n = 1;
405 t1.vin[0].scriptSig << std::vector<unsigned char>(65, 0);
406 t1.vin[1].prevout.hash = dummyTransactions[1].GetHash();
407 t1.vin[1].prevout.n = 0;
408 t1.vin[1].scriptSig << std::vector<unsigned char>(65, 0) << std::vector<unsigned char>(33, 4);
409 t1.vin[2].prevout.hash = dummyTransactions[1].GetHash();
410 t1.vin[2].prevout.n = 1;
411 t1.vin[2].scriptSig << std::vector<unsigned char>(65, 0) << std::vector<unsigned char>(33, 4);
412 t1.vout.resize(2);
413 t1.vout[0].nValue = 90*CENT;
414 t1.vout[0].scriptPubKey << OP_1;
415
417}
418
419static void CreateCreditAndSpend(const FillableSigningProvider& keystore, const CScript& outscript, CTransactionRef& output, CMutableTransaction& input, bool success = true)
420{
421 CMutableTransaction outputm;
422 outputm.version = 1;
423 outputm.vin.resize(1);
424 outputm.vin[0].prevout.SetNull();
425 outputm.vin[0].scriptSig = CScript();
426 outputm.vout.resize(1);
427 outputm.vout[0].nValue = 1;
428 outputm.vout[0].scriptPubKey = outscript;
429 DataStream ssout;
430 ssout << TX_WITH_WITNESS(outputm);
431 ssout >> TX_WITH_WITNESS(output);
432 assert(output->vin.size() == 1);
433 assert(output->vin[0] == outputm.vin[0]);
434 assert(output->vout.size() == 1);
435 assert(output->vout[0] == outputm.vout[0]);
436
437 CMutableTransaction inputm;
438 inputm.version = 1;
439 inputm.vin.resize(1);
440 inputm.vin[0].prevout.hash = output->GetHash();
441 inputm.vin[0].prevout.n = 0;
442 inputm.vout.resize(1);
443 inputm.vout[0].nValue = 1;
444 inputm.vout[0].scriptPubKey = CScript();
445 SignatureData empty;
446 bool ret = SignSignature(keystore, *output, inputm, 0, SIGHASH_ALL, empty);
447 assert(ret == success);
448 DataStream ssin;
449 ssin << TX_WITH_WITNESS(inputm);
450 ssin >> TX_WITH_WITNESS(input);
451 assert(input.vin.size() == 1);
452 assert(input.vin[0] == inputm.vin[0]);
453 assert(input.vout.size() == 1);
454 assert(input.vout[0] == inputm.vout[0]);
455 assert(input.vin[0].scriptWitness.stack == inputm.vin[0].scriptWitness.stack);
456}
457
458static void CheckWithFlag(const CTransactionRef& output, const CMutableTransaction& input, script_verify_flags flags, bool success)
459{
460 ScriptError error;
461 CTransaction inputi(input);
462 bool ret = VerifyScript(inputi.vin[0].scriptSig, output->vout[0].scriptPubKey, &inputi.vin[0].scriptWitness, flags, TransactionSignatureChecker(&inputi, 0, output->vout[0].nValue, MissingDataBehavior::ASSERT_FAIL), &error);
463 assert(ret == success);
464}
465
466static CScript PushAll(const std::vector<valtype>& values)
467{
468 CScript result;
469 for (const valtype& v : values) {
470 if (v.size() == 0) {
471 result << OP_0;
472 } else if (v.size() == 1 && v[0] >= 1 && v[0] <= 16) {
473 result << CScript::EncodeOP_N(v[0]);
474 } else if (v.size() == 1 && v[0] == 0x81) {
475 result << OP_1NEGATE;
476 } else {
477 result << v;
478 }
479 }
480 return result;
481}
482
483static void ReplaceRedeemScript(CScript& script, const CScript& redeemScript)
484{
485 std::vector<valtype> stack;
487 assert(stack.size() > 0);
488 stack.back() = std::vector<unsigned char>(redeemScript.begin(), redeemScript.end());
489 script = PushAll(stack);
490}
491
492BOOST_AUTO_TEST_CASE(test_big_witness_transaction)
493{
495 mtx.version = 1;
496
497 CKey key = GenerateRandomKey(); // Need to use compressed keys in segwit or the signing will fail
499 BOOST_CHECK(keystore.AddKeyPubKey(key, key.GetPubKey()));
500 CKeyID hash = key.GetPubKey().GetID();
501 CScript scriptPubKey = CScript() << OP_0 << std::vector<unsigned char>(hash.begin(), hash.end());
502
503 std::vector<int> sigHashes;
504 sigHashes.push_back(SIGHASH_NONE | SIGHASH_ANYONECANPAY);
505 sigHashes.push_back(SIGHASH_SINGLE | SIGHASH_ANYONECANPAY);
506 sigHashes.push_back(SIGHASH_ALL | SIGHASH_ANYONECANPAY);
507 sigHashes.push_back(SIGHASH_NONE);
508 sigHashes.push_back(SIGHASH_SINGLE);
509 sigHashes.push_back(SIGHASH_ALL);
510
511 // create a big transaction of 4500 inputs signed by the same key
512 for(uint32_t ij = 0; ij < 4500; ij++) {
513 uint32_t i = mtx.vin.size();
514 COutPoint outpoint{Txid{"0000000000000000000000000000000000000000000000000000000000000100"}, i};
515
516 mtx.vin.resize(mtx.vin.size() + 1);
517 mtx.vin[i].prevout = outpoint;
518 mtx.vin[i].scriptSig = CScript();
519
520 mtx.vout.resize(mtx.vout.size() + 1);
521 mtx.vout[i].nValue = 1000;
522 mtx.vout[i].scriptPubKey = CScript() << OP_1;
523 }
524
525 // sign all inputs
526 for(uint32_t i = 0; i < mtx.vin.size(); i++) {
527 SignatureData empty;
528 bool hashSigned = SignSignature(keystore, scriptPubKey, mtx, i, 1000, sigHashes.at(i % sigHashes.size()), empty);
529 assert(hashSigned);
530 }
531
532 DataStream ssout;
533 ssout << TX_WITH_WITNESS(mtx);
535
536 // check all inputs concurrently, with the cache
538 CCheckQueue<CScriptCheck> scriptcheckqueue(/*batch_size=*/128, /*worker_threads_num=*/20);
539 CCheckQueueControl<CScriptCheck> control(scriptcheckqueue);
540
541 std::vector<Coin> coins;
542 for(uint32_t i = 0; i < mtx.vin.size(); i++) {
543 Coin coin;
544 coin.nHeight = 1;
545 coin.fCoinBase = false;
546 coin.out.nValue = 1000;
547 coin.out.scriptPubKey = scriptPubKey;
548 coins.emplace_back(std::move(coin));
549 }
550
552
553 for(uint32_t i = 0; i < mtx.vin.size(); i++) {
554 std::vector<CScriptCheck> vChecks;
555 vChecks.emplace_back(coins[tx.vin[i].prevout.n].out, tx, signature_cache, i, SCRIPT_VERIFY_P2SH | SCRIPT_VERIFY_WITNESS, false, &txdata);
556 control.Add(std::move(vChecks));
557 }
558
559 bool controlCheck = !control.Complete().has_value();
560 assert(controlCheck);
561}
562
564{
565 SignatureData sigdata;
566 sigdata = DataFromTransaction(input1, 0, tx->vout[0]);
567 sigdata.MergeSignatureData(DataFromTransaction(input2, 0, tx->vout[0]));
568 ProduceSignature(DUMMY_SIGNING_PROVIDER, MutableTransactionSignatureCreator(input1, 0, tx->vout[0].nValue, {.sighash_type = SIGHASH_DEFAULT}), tx->vout[0].scriptPubKey, sigdata);
569 return sigdata;
570}
571
573{
574 FillableSigningProvider keystore, keystore2;
575 CKey key1 = GenerateRandomKey();
576 CKey key2 = GenerateRandomKey();
577 CKey key3 = GenerateRandomKey();
578 CKey key1L = GenerateRandomKey(/*compressed=*/false);
579 CKey key2L = GenerateRandomKey(/*compressed=*/false);
580 CPubKey pubkey1 = key1.GetPubKey();
581 CPubKey pubkey2 = key2.GetPubKey();
582 CPubKey pubkey3 = key3.GetPubKey();
583 CPubKey pubkey1L = key1L.GetPubKey();
584 CPubKey pubkey2L = key2L.GetPubKey();
585 BOOST_CHECK(keystore.AddKeyPubKey(key1, pubkey1));
586 BOOST_CHECK(keystore.AddKeyPubKey(key2, pubkey2));
587 BOOST_CHECK(keystore.AddKeyPubKey(key1L, pubkey1L));
588 BOOST_CHECK(keystore.AddKeyPubKey(key2L, pubkey2L));
589 CScript scriptPubkey1, scriptPubkey2, scriptPubkey1L, scriptPubkey2L, scriptMulti;
590 scriptPubkey1 << ToByteVector(pubkey1) << OP_CHECKSIG;
591 scriptPubkey2 << ToByteVector(pubkey2) << OP_CHECKSIG;
592 scriptPubkey1L << ToByteVector(pubkey1L) << OP_CHECKSIG;
593 scriptPubkey2L << ToByteVector(pubkey2L) << OP_CHECKSIG;
594 std::vector<CPubKey> oneandthree;
595 oneandthree.push_back(pubkey1);
596 oneandthree.push_back(pubkey3);
597 scriptMulti = GetScriptForMultisig(2, oneandthree);
598 BOOST_CHECK(keystore.AddCScript(scriptPubkey1));
599 BOOST_CHECK(keystore.AddCScript(scriptPubkey2));
600 BOOST_CHECK(keystore.AddCScript(scriptPubkey1L));
601 BOOST_CHECK(keystore.AddCScript(scriptPubkey2L));
602 BOOST_CHECK(keystore.AddCScript(scriptMulti));
603 CScript destination_script_1, destination_script_2, destination_script_1L, destination_script_2L, destination_script_multi;
604 destination_script_1 = GetScriptForDestination(WitnessV0KeyHash(pubkey1));
605 destination_script_2 = GetScriptForDestination(WitnessV0KeyHash(pubkey2));
606 destination_script_1L = GetScriptForDestination(WitnessV0KeyHash(pubkey1L));
607 destination_script_2L = GetScriptForDestination(WitnessV0KeyHash(pubkey2L));
608 destination_script_multi = GetScriptForDestination(WitnessV0ScriptHash(scriptMulti));
609 BOOST_CHECK(keystore.AddCScript(destination_script_1));
610 BOOST_CHECK(keystore.AddCScript(destination_script_2));
611 BOOST_CHECK(keystore.AddCScript(destination_script_1L));
612 BOOST_CHECK(keystore.AddCScript(destination_script_2L));
613 BOOST_CHECK(keystore.AddCScript(destination_script_multi));
614 BOOST_CHECK(keystore2.AddCScript(scriptMulti));
615 BOOST_CHECK(keystore2.AddCScript(destination_script_multi));
616 BOOST_CHECK(keystore2.AddKeyPubKey(key3, pubkey3));
617
618 CTransactionRef output1, output2;
619 CMutableTransaction input1, input2;
620
621 // Normal pay-to-compressed-pubkey.
622 CreateCreditAndSpend(keystore, scriptPubkey1, output1, input1);
623 CreateCreditAndSpend(keystore, scriptPubkey2, output2, input2);
624 CheckWithFlag(output1, input1, SCRIPT_VERIFY_NONE, true);
625 CheckWithFlag(output1, input1, SCRIPT_VERIFY_P2SH, true);
627 CheckWithFlag(output1, input1, STANDARD_SCRIPT_VERIFY_FLAGS, true);
628 CheckWithFlag(output1, input2, SCRIPT_VERIFY_NONE, false);
629 CheckWithFlag(output1, input2, SCRIPT_VERIFY_P2SH, false);
630 CheckWithFlag(output1, input2, SCRIPT_VERIFY_WITNESS | SCRIPT_VERIFY_P2SH, false);
631 CheckWithFlag(output1, input2, STANDARD_SCRIPT_VERIFY_FLAGS, false);
632
633 // P2SH pay-to-compressed-pubkey.
634 CreateCreditAndSpend(keystore, GetScriptForDestination(ScriptHash(scriptPubkey1)), output1, input1);
635 CreateCreditAndSpend(keystore, GetScriptForDestination(ScriptHash(scriptPubkey2)), output2, input2);
636 ReplaceRedeemScript(input2.vin[0].scriptSig, scriptPubkey1);
637 CheckWithFlag(output1, input1, SCRIPT_VERIFY_NONE, true);
638 CheckWithFlag(output1, input1, SCRIPT_VERIFY_P2SH, true);
640 CheckWithFlag(output1, input1, STANDARD_SCRIPT_VERIFY_FLAGS, true);
641 CheckWithFlag(output1, input2, SCRIPT_VERIFY_NONE, true);
642 CheckWithFlag(output1, input2, SCRIPT_VERIFY_P2SH, false);
643 CheckWithFlag(output1, input2, SCRIPT_VERIFY_WITNESS | SCRIPT_VERIFY_P2SH, false);
644 CheckWithFlag(output1, input2, STANDARD_SCRIPT_VERIFY_FLAGS, false);
645
646 // Witness pay-to-compressed-pubkey (v0).
647 CreateCreditAndSpend(keystore, destination_script_1, output1, input1);
648 CreateCreditAndSpend(keystore, destination_script_2, output2, input2);
649 CheckWithFlag(output1, input1, SCRIPT_VERIFY_NONE, true);
650 CheckWithFlag(output1, input1, SCRIPT_VERIFY_P2SH, true);
652 CheckWithFlag(output1, input1, STANDARD_SCRIPT_VERIFY_FLAGS, true);
653 CheckWithFlag(output1, input2, SCRIPT_VERIFY_NONE, true);
654 CheckWithFlag(output1, input2, SCRIPT_VERIFY_P2SH, true);
655 CheckWithFlag(output1, input2, SCRIPT_VERIFY_WITNESS | SCRIPT_VERIFY_P2SH, false);
656 CheckWithFlag(output1, input2, STANDARD_SCRIPT_VERIFY_FLAGS, false);
657
658 // P2SH witness pay-to-compressed-pubkey (v0).
659 CreateCreditAndSpend(keystore, GetScriptForDestination(ScriptHash(destination_script_1)), output1, input1);
660 CreateCreditAndSpend(keystore, GetScriptForDestination(ScriptHash(destination_script_2)), output2, input2);
661 ReplaceRedeemScript(input2.vin[0].scriptSig, destination_script_1);
662 CheckWithFlag(output1, input1, SCRIPT_VERIFY_NONE, true);
663 CheckWithFlag(output1, input1, SCRIPT_VERIFY_P2SH, true);
665 CheckWithFlag(output1, input1, STANDARD_SCRIPT_VERIFY_FLAGS, true);
666 CheckWithFlag(output1, input2, SCRIPT_VERIFY_NONE, true);
667 CheckWithFlag(output1, input2, SCRIPT_VERIFY_P2SH, true);
668 CheckWithFlag(output1, input2, SCRIPT_VERIFY_WITNESS | SCRIPT_VERIFY_P2SH, false);
669 CheckWithFlag(output1, input2, STANDARD_SCRIPT_VERIFY_FLAGS, false);
670
671 // Normal pay-to-uncompressed-pubkey.
672 CreateCreditAndSpend(keystore, scriptPubkey1L, output1, input1);
673 CreateCreditAndSpend(keystore, scriptPubkey2L, output2, input2);
674 CheckWithFlag(output1, input1, SCRIPT_VERIFY_NONE, true);
675 CheckWithFlag(output1, input1, SCRIPT_VERIFY_P2SH, true);
677 CheckWithFlag(output1, input1, STANDARD_SCRIPT_VERIFY_FLAGS, true);
678 CheckWithFlag(output1, input2, SCRIPT_VERIFY_NONE, false);
679 CheckWithFlag(output1, input2, SCRIPT_VERIFY_P2SH, false);
680 CheckWithFlag(output1, input2, SCRIPT_VERIFY_WITNESS | SCRIPT_VERIFY_P2SH, false);
681 CheckWithFlag(output1, input2, STANDARD_SCRIPT_VERIFY_FLAGS, false);
682
683 // P2SH pay-to-uncompressed-pubkey.
684 CreateCreditAndSpend(keystore, GetScriptForDestination(ScriptHash(scriptPubkey1L)), output1, input1);
685 CreateCreditAndSpend(keystore, GetScriptForDestination(ScriptHash(scriptPubkey2L)), output2, input2);
686 ReplaceRedeemScript(input2.vin[0].scriptSig, scriptPubkey1L);
687 CheckWithFlag(output1, input1, SCRIPT_VERIFY_NONE, true);
688 CheckWithFlag(output1, input1, SCRIPT_VERIFY_P2SH, true);
690 CheckWithFlag(output1, input1, STANDARD_SCRIPT_VERIFY_FLAGS, true);
691 CheckWithFlag(output1, input2, SCRIPT_VERIFY_NONE, true);
692 CheckWithFlag(output1, input2, SCRIPT_VERIFY_P2SH, false);
693 CheckWithFlag(output1, input2, SCRIPT_VERIFY_WITNESS | SCRIPT_VERIFY_P2SH, false);
694 CheckWithFlag(output1, input2, STANDARD_SCRIPT_VERIFY_FLAGS, false);
695
696 // Signing disabled for witness pay-to-uncompressed-pubkey (v1).
697 CreateCreditAndSpend(keystore, destination_script_1L, output1, input1, false);
698 CreateCreditAndSpend(keystore, destination_script_2L, output2, input2, false);
699
700 // Signing disabled for P2SH witness pay-to-uncompressed-pubkey (v1).
701 CreateCreditAndSpend(keystore, GetScriptForDestination(ScriptHash(destination_script_1L)), output1, input1, false);
702 CreateCreditAndSpend(keystore, GetScriptForDestination(ScriptHash(destination_script_2L)), output2, input2, false);
703
704 // Normal 2-of-2 multisig
705 CreateCreditAndSpend(keystore, scriptMulti, output1, input1, false);
706 CheckWithFlag(output1, input1, SCRIPT_VERIFY_NONE, false);
707 CreateCreditAndSpend(keystore2, scriptMulti, output2, input2, false);
708 CheckWithFlag(output2, input2, SCRIPT_VERIFY_NONE, false);
709 BOOST_CHECK(output1->Equals(*output2));
710 UpdateInput(input1.vin[0], CombineSignatures(input1, input2, output1));
711 CheckWithFlag(output1, input1, STANDARD_SCRIPT_VERIFY_FLAGS, true);
712
713 // P2SH 2-of-2 multisig
714 CreateCreditAndSpend(keystore, GetScriptForDestination(ScriptHash(scriptMulti)), output1, input1, false);
715 CheckWithFlag(output1, input1, SCRIPT_VERIFY_NONE, true);
716 CheckWithFlag(output1, input1, SCRIPT_VERIFY_P2SH, false);
717 CreateCreditAndSpend(keystore2, GetScriptForDestination(ScriptHash(scriptMulti)), output2, input2, false);
718 CheckWithFlag(output2, input2, SCRIPT_VERIFY_NONE, true);
719 CheckWithFlag(output2, input2, SCRIPT_VERIFY_P2SH, false);
720 BOOST_CHECK(output1->Equals(*output2));
721 UpdateInput(input1.vin[0], CombineSignatures(input1, input2, output1));
722 CheckWithFlag(output1, input1, SCRIPT_VERIFY_P2SH, true);
723 CheckWithFlag(output1, input1, STANDARD_SCRIPT_VERIFY_FLAGS, true);
724
725 // Witness 2-of-2 multisig
726 CreateCreditAndSpend(keystore, destination_script_multi, output1, input1, false);
727 CheckWithFlag(output1, input1, SCRIPT_VERIFY_NONE, true);
728 CheckWithFlag(output1, input1, SCRIPT_VERIFY_P2SH | SCRIPT_VERIFY_WITNESS, false);
729 CreateCreditAndSpend(keystore2, destination_script_multi, output2, input2, false);
730 CheckWithFlag(output2, input2, SCRIPT_VERIFY_NONE, true);
731 CheckWithFlag(output2, input2, SCRIPT_VERIFY_P2SH | SCRIPT_VERIFY_WITNESS, false);
732 BOOST_CHECK(output1->Equals(*output2));
733 UpdateInput(input1.vin[0], CombineSignatures(input1, input2, output1));
735 CheckWithFlag(output1, input1, STANDARD_SCRIPT_VERIFY_FLAGS, true);
736
737 // P2SH witness 2-of-2 multisig
738 CreateCreditAndSpend(keystore, GetScriptForDestination(ScriptHash(destination_script_multi)), output1, input1, false);
739 CheckWithFlag(output1, input1, SCRIPT_VERIFY_P2SH, true);
740 CheckWithFlag(output1, input1, SCRIPT_VERIFY_P2SH | SCRIPT_VERIFY_WITNESS, false);
741 CreateCreditAndSpend(keystore2, GetScriptForDestination(ScriptHash(destination_script_multi)), output2, input2, false);
742 CheckWithFlag(output2, input2, SCRIPT_VERIFY_P2SH, true);
743 CheckWithFlag(output2, input2, SCRIPT_VERIFY_P2SH | SCRIPT_VERIFY_WITNESS, false);
744 BOOST_CHECK(output1->Equals(*output2));
745 UpdateInput(input1.vin[0], CombineSignatures(input1, input2, output1));
747 CheckWithFlag(output1, input1, STANDARD_SCRIPT_VERIFY_FLAGS, true);
748}
749
750BOOST_AUTO_TEST_CASE(test_IsStandard)
751{
754 std::vector<CMutableTransaction> dummyTransactions =
755 SetupDummyInputs(keystore, coins, {11*CENT, 50*CENT, 21*CENT, 22*CENT});
756
758 t.vin.resize(1);
759 t.vin[0].prevout.hash = dummyTransactions[0].GetHash();
760 t.vin[0].prevout.n = 1;
761 t.vin[0].scriptSig << std::vector<unsigned char>(65, 0);
762 t.vout.resize(1);
763 t.vout[0].nValue = 90*CENT;
764 CKey key = GenerateRandomKey();
765 t.vout[0].scriptPubKey = GetScriptForDestination(PKHash(key.GetPubKey()));
766
767 constexpr auto CheckIsStandard = [](const auto& t, const unsigned int max_op_return_relay = MAX_OP_RETURN_RELAY) {
768 std::string reason;
769 BOOST_CHECK(IsStandardTx(CTransaction{t}, max_op_return_relay, g_bare_multi, g_dust, reason));
770 BOOST_CHECK(reason.empty());
771 };
772 constexpr auto CheckIsNotStandard = [](const auto& t, const std::string& reason_in, const unsigned int max_op_return_relay = MAX_OP_RETURN_RELAY) {
773 std::string reason;
774 BOOST_CHECK(!IsStandardTx(CTransaction{t}, max_op_return_relay, g_bare_multi, g_dust, reason));
775 BOOST_CHECK_EQUAL(reason_in, reason);
776 };
777
778 CheckIsStandard(t);
779
780 // Check dust with default relay fee:
781 CAmount nDustThreshold = 182 * g_dust.GetFeePerK() / 1000;
782 BOOST_CHECK_EQUAL(nDustThreshold, 546);
783
784 // Add dust outputs up to allowed maximum, still standard!
785 for (size_t i{0}; i < MAX_DUST_OUTPUTS_PER_TX; ++i) {
786 t.vout.emplace_back(0, t.vout[0].scriptPubKey);
787 CheckIsStandard(t);
788 }
789
790 // dust:
791 t.vout[0].nValue = nDustThreshold - 1;
792 CheckIsNotStandard(t, "dust");
793 // not dust:
794 t.vout[0].nValue = nDustThreshold;
795 CheckIsStandard(t);
796
797 // Disallowed version
798 t.version = std::numeric_limits<uint32_t>::max();
799 CheckIsNotStandard(t, "version");
800
801 t.version = 0;
802 CheckIsNotStandard(t, "version");
803
804 t.version = TX_MAX_STANDARD_VERSION + 1;
805 CheckIsNotStandard(t, "version");
806
807 // Allowed version
808 t.version = 1;
809 CheckIsStandard(t);
810
811 t.version = 2;
812 CheckIsStandard(t);
813
814 // Check dust with odd relay fee to verify rounding:
815 // nDustThreshold = 182 * 3702 / 1000
816 g_dust = CFeeRate(3702);
817 // dust:
818 t.vout[0].nValue = 674 - 1;
819 CheckIsNotStandard(t, "dust");
820 // not dust:
821 t.vout[0].nValue = 674;
822 CheckIsStandard(t);
824
825 t.vout[0].scriptPubKey = CScript() << OP_1;
826 CheckIsNotStandard(t, "scriptpubkey");
827
828 // Custom 83-byte TxoutType::NULL_DATA (standard with max_op_return_relay of 83)
829 t.vout[0].scriptPubKey = CScript() << OP_RETURN << "04678afdb0fe5548271967f1a67130b7105cd6a828e03909a67962e0ea1f61deb649f6bc3f4cef3804678afdb0fe5548271967f1a67130b7105cd6a828e03909a67962e0ea1f61deb649f6bc3f4cef38"_hex;
830 BOOST_CHECK_EQUAL(83, t.vout[0].scriptPubKey.size());
831 CheckIsStandard(t, /*max_op_return_relay=*/83);
832
833 // Non-standard if max_op_return_relay datacarrier arg is one less
834 CheckIsNotStandard(t, "datacarrier", /*max_op_return_relay=*/82);
835
836 // Data payload can be encoded in any way...
837 t.vout[0].scriptPubKey = CScript() << OP_RETURN << ""_hex;
838 CheckIsStandard(t);
839 t.vout[0].scriptPubKey = CScript() << OP_RETURN << "00"_hex << "01"_hex;
840 CheckIsStandard(t);
841 // OP_RESERVED *is* considered to be a PUSHDATA type opcode by IsPushOnly()!
842 t.vout[0].scriptPubKey = CScript() << OP_RETURN << OP_RESERVED << -1 << 0 << "01"_hex << 2 << 3 << 4 << 5 << 6 << 7 << 8 << 9 << 10 << 11 << 12 << 13 << 14 << 15 << 16;
843 CheckIsStandard(t);
844 t.vout[0].scriptPubKey = CScript() << OP_RETURN << 0 << "01"_hex << 2 << "ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff"_hex;
845 CheckIsStandard(t);
846
847 // ...so long as it only contains PUSHDATA's
848 t.vout[0].scriptPubKey = CScript() << OP_RETURN << OP_RETURN;
849 CheckIsNotStandard(t, "scriptpubkey");
850
851 // TxoutType::NULL_DATA w/o PUSHDATA
852 t.vout.resize(1);
853 t.vout[0].scriptPubKey = CScript() << OP_RETURN;
854 CheckIsStandard(t);
855
856 // Multiple TxoutType::NULL_DATA are permitted
857 t.vout.resize(2);
858 t.vout[0].scriptPubKey = CScript() << OP_RETURN << "04678afdb0fe5548271967f1a67130b7105cd6a828e03909a67962e0ea1f61deb649f6bc3f4cef38"_hex;
859 t.vout[0].nValue = 0;
860 t.vout[1].scriptPubKey = CScript() << OP_RETURN << "04678afdb0fe5548271967f1a67130b7105cd6a828e03909a67962e0ea1f61deb649f6bc3f4cef38"_hex;
861 t.vout[1].nValue = 0;
862 CheckIsStandard(t);
863
864 t.vout[0].scriptPubKey = CScript() << OP_RETURN << "04678afdb0fe5548271967f1a67130b7105cd6a828e03909a67962e0ea1f61deb649f6bc3f4cef38"_hex;
865 t.vout[1].scriptPubKey = CScript() << OP_RETURN;
866 CheckIsStandard(t);
867
868 t.vout[0].scriptPubKey = CScript() << OP_RETURN;
869 t.vout[1].scriptPubKey = CScript() << OP_RETURN;
870 CheckIsStandard(t);
871
872 t.vout[0].scriptPubKey = CScript() << OP_RETURN << "04678afdb0fe5548271967f1a67130b7105cd6a828e03909a67962e0ea1f61deb649f6bc3f4cef3804678afdb0fe5548271967f1a67130b7105cd6a828e03909a67962e0ea1f61deb649f6bc3f4cef38"_hex;
873 t.vout[1].scriptPubKey = CScript() << OP_RETURN << "04678afdb0fe5548271967f1a67130b7105cd6a828e03909a67962e0ea1f61deb649f6bc3f4cef3804678afdb0fe5548271967f1a67130b7105cd6a828e03909a67962e0ea1f61deb649f6bc3f4cef38"_hex;
874 const auto datacarrier_size = t.vout[0].scriptPubKey.size() + t.vout[1].scriptPubKey.size();
875 CheckIsStandard(t); // Default max relay should never trigger
876 CheckIsStandard(t, /*max_op_return_relay=*/datacarrier_size);
877 CheckIsNotStandard(t, "datacarrier", /*max_op_return_relay=*/datacarrier_size-1);
878
879 // Check large scriptSig (non-standard if size is >1650 bytes)
880 t.vout.resize(1);
881 t.vout[0].nValue = MAX_MONEY;
882 t.vout[0].scriptPubKey = GetScriptForDestination(PKHash(key.GetPubKey()));
883 // OP_PUSHDATA2 with len (3 bytes) + data (1647 bytes) = 1650 bytes
884 t.vin[0].scriptSig = CScript() << std::vector<unsigned char>(1647, 0); // 1650
885 CheckIsStandard(t);
886
887 t.vin[0].scriptSig = CScript() << std::vector<unsigned char>(1648, 0); // 1651
888 CheckIsNotStandard(t, "scriptsig-size");
889
890 // Check scriptSig format (non-standard if there are any other ops than just PUSHs)
891 t.vin[0].scriptSig = CScript()
892 << OP_TRUE << OP_0 << OP_1NEGATE << OP_16 // OP_n (single byte pushes: n = 1, 0, -1, 16)
893 << std::vector<unsigned char>(75, 0) // OP_PUSHx [...x bytes...]
894 << std::vector<unsigned char>(235, 0) // OP_PUSHDATA1 x [...x bytes...]
895 << std::vector<unsigned char>(1234, 0) // OP_PUSHDATA2 x [...x bytes...]
896 << OP_9;
897 CheckIsStandard(t);
898
899 const std::vector<unsigned char> non_push_ops = { // arbitrary set of non-push operations
902
903 CScript::const_iterator pc = t.vin[0].scriptSig.begin();
904 while (pc < t.vin[0].scriptSig.end()) {
905 opcodetype opcode;
906 CScript::const_iterator prev_pc = pc;
907 t.vin[0].scriptSig.GetOp(pc, opcode); // advance to next op
908 // for the sake of simplicity, we only replace single-byte push operations
909 if (opcode >= 1 && opcode <= OP_PUSHDATA4)
910 continue;
911
912 int index = prev_pc - t.vin[0].scriptSig.begin();
913 unsigned char orig_op = *prev_pc; // save op
914 // replace current push-op with each non-push-op
915 for (auto op : non_push_ops) {
916 t.vin[0].scriptSig[index] = op;
917 CheckIsNotStandard(t, "scriptsig-not-pushonly");
918 }
919 t.vin[0].scriptSig[index] = orig_op; // restore op
920 CheckIsStandard(t);
921 }
922
923 // Check tx-size (non-standard if transaction weight is > MAX_STANDARD_TX_WEIGHT)
924 t.vin.clear();
925 t.vin.resize(2438); // size per input (empty scriptSig): 41 bytes
926 t.vout[0].scriptPubKey = CScript() << OP_RETURN << std::vector<unsigned char>(19, 0); // output size: 30 bytes
927 // tx header: 12 bytes => 48 weight units
928 // 2438 inputs: 2438*41 = 99958 bytes => 399832 weight units
929 // 1 output: 30 bytes => 120 weight units
930 // ======================================
931 // total: 400000 weight units
933 CheckIsStandard(t);
934
935 // increase output size by one byte, so we end up with 400004 weight units
936 t.vout[0].scriptPubKey = CScript() << OP_RETURN << std::vector<unsigned char>(20, 0); // output size: 31 bytes
938 CheckIsNotStandard(t, "tx-size");
939
940 // Check bare multisig (standard if policy flag g_bare_multi is set)
941 g_bare_multi = true;
942 t.vout[0].scriptPubKey = GetScriptForMultisig(1, {key.GetPubKey()}); // simple 1-of-1
943 t.vin.resize(1);
944 t.vin[0].scriptSig = CScript() << std::vector<unsigned char>(65, 0);
945 CheckIsStandard(t);
946
947 g_bare_multi = false;
948 CheckIsNotStandard(t, "bare-multisig");
950
951 // Add dust outputs up to allowed maximum
952 assert(t.vout.size() == 1);
953 t.vout.insert(t.vout.end(), MAX_DUST_OUTPUTS_PER_TX, {0, t.vout[0].scriptPubKey});
954
955 // Check compressed P2PK outputs dust threshold (must have leading 02 or 03)
956 t.vout[0].scriptPubKey = CScript() << std::vector<unsigned char>(33, 0x02) << OP_CHECKSIG;
957 t.vout[0].nValue = 576;
958 CheckIsStandard(t);
959 t.vout[0].nValue = 575;
960 CheckIsNotStandard(t, "dust");
961
962 // Check uncompressed P2PK outputs dust threshold (must have leading 04/06/07)
963 t.vout[0].scriptPubKey = CScript() << std::vector<unsigned char>(65, 0x04) << OP_CHECKSIG;
964 t.vout[0].nValue = 672;
965 CheckIsStandard(t);
966 t.vout[0].nValue = 671;
967 CheckIsNotStandard(t, "dust");
968
969 // Check P2PKH outputs dust threshold
970 t.vout[0].scriptPubKey = CScript() << OP_DUP << OP_HASH160 << std::vector<unsigned char>(20, 0) << OP_EQUALVERIFY << OP_CHECKSIG;
971 t.vout[0].nValue = 546;
972 CheckIsStandard(t);
973 t.vout[0].nValue = 545;
974 CheckIsNotStandard(t, "dust");
975
976 // Check P2SH outputs dust threshold
977 t.vout[0].scriptPubKey = CScript() << OP_HASH160 << std::vector<unsigned char>(20, 0) << OP_EQUAL;
978 t.vout[0].nValue = 540;
979 CheckIsStandard(t);
980 t.vout[0].nValue = 539;
981 CheckIsNotStandard(t, "dust");
982
983 // Check P2WPKH outputs dust threshold
984 t.vout[0].scriptPubKey = CScript() << OP_0 << std::vector<unsigned char>(20, 0);
985 t.vout[0].nValue = 294;
986 CheckIsStandard(t);
987 t.vout[0].nValue = 293;
988 CheckIsNotStandard(t, "dust");
989
990 // Check P2WSH outputs dust threshold
991 t.vout[0].scriptPubKey = CScript() << OP_0 << std::vector<unsigned char>(32, 0);
992 t.vout[0].nValue = 330;
993 CheckIsStandard(t);
994 t.vout[0].nValue = 329;
995 CheckIsNotStandard(t, "dust");
996
997 // Check P2TR outputs dust threshold (Invalid xonly key ok!)
998 t.vout[0].scriptPubKey = CScript() << OP_1 << std::vector<unsigned char>(32, 0);
999 t.vout[0].nValue = 330;
1000 CheckIsStandard(t);
1001 t.vout[0].nValue = 329;
1002 CheckIsNotStandard(t, "dust");
1003
1004 // Check future Witness Program versions dust threshold (non-32-byte pushes are undefined for version 1)
1005 for (int op = OP_1; op <= OP_16; op += 1) {
1006 t.vout[0].scriptPubKey = CScript() << (opcodetype)op << std::vector<unsigned char>(2, 0);
1007 t.vout[0].nValue = 240;
1008 CheckIsStandard(t);
1009
1010 t.vout[0].nValue = 239;
1011 CheckIsNotStandard(t, "dust");
1012 }
1013
1014 // Check anchor outputs
1015 t.vout[0].scriptPubKey = CScript() << OP_1 << ANCHOR_BYTES;
1016 BOOST_CHECK(t.vout[0].scriptPubKey.IsPayToAnchor());
1017 t.vout[0].nValue = 240;
1018 CheckIsStandard(t);
1019 t.vout[0].nValue = 239;
1020 CheckIsNotStandard(t, "dust");
1021}
1022
1023BOOST_AUTO_TEST_CASE(max_standard_legacy_sigops)
1024{
1026 CKey key;
1027 key.MakeNewKey(true);
1028
1029 // Create a pathological P2SH script padded with as many sigops as is standard.
1030 CScript max_sigops_redeem_script{CScript() << std::vector<unsigned char>{} << key.GetPubKey()};
1031 for (unsigned i{0}; i < MAX_P2SH_SIGOPS - 1; ++i) max_sigops_redeem_script << OP_2DUP << OP_CHECKSIG << OP_DROP;
1032 max_sigops_redeem_script << OP_CHECKSIG << OP_NOT;
1033 const CScript max_sigops_p2sh{GetScriptForDestination(ScriptHash(max_sigops_redeem_script))};
1034
1035 // Create a transaction fanning out as many such P2SH outputs as is standard to spend in a
1036 // single transaction, and a transaction spending them.
1037 CMutableTransaction tx_create, tx_max_sigops;
1038 const unsigned p2sh_inputs_count{MAX_TX_LEGACY_SIGOPS / MAX_P2SH_SIGOPS};
1039 tx_create.vout.reserve(p2sh_inputs_count);
1040 for (unsigned i{0}; i < p2sh_inputs_count; ++i) {
1041 tx_create.vout.emplace_back(424242 + i, max_sigops_p2sh);
1042 }
1043 auto prev_txid{tx_create.GetHash()};
1044 tx_max_sigops.vin.reserve(p2sh_inputs_count);
1045 for (unsigned i{0}; i < p2sh_inputs_count; ++i) {
1046 tx_max_sigops.vin.emplace_back(prev_txid, i, CScript() << ToByteVector(max_sigops_redeem_script));
1047 }
1048
1049 // p2sh_inputs_count is truncated to 166 (from 166.6666..)
1050 BOOST_CHECK_LT(p2sh_inputs_count * MAX_P2SH_SIGOPS, MAX_TX_LEGACY_SIGOPS);
1051 AddCoins(coins, CTransaction(tx_create), 0, false);
1052
1053 // 2490 sigops is below the limit.
1054 BOOST_CHECK_EQUAL(GetP2SHSigOpCount(CTransaction(tx_max_sigops), coins), 2490);
1055 BOOST_CHECK(::ValidateInputsStandardness(CTransaction(tx_max_sigops), coins).IsValid());
1056
1057 // Adding one more input will bump this to 2505, hitting the limit.
1058 tx_create.vout.emplace_back(424242, max_sigops_p2sh);
1059 prev_txid = tx_create.GetHash();
1060 for (unsigned i{0}; i < p2sh_inputs_count; ++i) {
1061 tx_max_sigops.vin[i] = CTxIn(COutPoint(prev_txid, i), CScript() << ToByteVector(max_sigops_redeem_script));
1062 }
1063 tx_max_sigops.vin.emplace_back(prev_txid, p2sh_inputs_count, CScript() << ToByteVector(max_sigops_redeem_script));
1064 AddCoins(coins, CTransaction(tx_create), 0, false);
1065 BOOST_CHECK_GT((p2sh_inputs_count + 1) * MAX_P2SH_SIGOPS, MAX_TX_LEGACY_SIGOPS);
1066 auto legacy_sigops_count = GetP2SHSigOpCount(CTransaction(tx_max_sigops), coins);
1067 BOOST_CHECK_EQUAL(legacy_sigops_count, 2505);
1068 std::string reject_reason("bad-txns-nonstandard-inputs");
1069 std::string sigop_limit_reject_debug_message("non-witness sigops exceed bip54 limit");
1070 {
1071 auto validation_state = ValidateInputsStandardness(CTransaction(tx_max_sigops), coins);
1072 BOOST_CHECK(validation_state.IsInvalid());
1073 BOOST_CHECK_EQUAL(validation_state.GetRejectReason(), reject_reason);
1074 BOOST_CHECK_EQUAL(validation_state.GetDebugMessage(), sigop_limit_reject_debug_message);
1075 }
1076
1077
1078 // Now, check the limit can be reached with regular P2PK outputs too. Use a separate
1079 // preparation transaction, to demonstrate spending coins from a single tx is irrelevant.
1080 CMutableTransaction tx_create_p2pk;
1081 const auto p2pk_script{CScript() << key.GetPubKey() << OP_CHECKSIG};
1082 unsigned p2pk_inputs_count{10}; // From 2490 to 2500.
1083 for (unsigned i{0}; i < p2pk_inputs_count; ++i) {
1084 tx_create_p2pk.vout.emplace_back(212121 + i, p2pk_script);
1085 }
1086 prev_txid = tx_create_p2pk.GetHash();
1087 tx_max_sigops.vin.resize(p2sh_inputs_count); // Drop the extra input.
1088 for (unsigned i{0}; i < p2pk_inputs_count; ++i) {
1089 tx_max_sigops.vin.emplace_back(prev_txid, i);
1090 }
1091 AddCoins(coins, CTransaction(tx_create_p2pk), 0, false);
1092
1093 // The transaction now contains exactly 2500 sigops, the check should pass.
1094 BOOST_CHECK_EQUAL(p2sh_inputs_count * MAX_P2SH_SIGOPS + p2pk_inputs_count * 1, MAX_TX_LEGACY_SIGOPS);
1095 BOOST_CHECK(::ValidateInputsStandardness(CTransaction(tx_max_sigops), coins).IsValid());
1096
1097 // Now, add some Segwit inputs. We add one for each defined Segwit output type. The limit
1098 // is exclusively on non-witness sigops and therefore those should not be counted.
1099 CMutableTransaction tx_create_segwit;
1100 const auto witness_script{CScript() << key.GetPubKey() << OP_CHECKSIG};
1101 tx_create_segwit.vout.emplace_back(121212, GetScriptForDestination(WitnessV0KeyHash(key.GetPubKey())));
1102 tx_create_segwit.vout.emplace_back(131313, GetScriptForDestination(WitnessV0ScriptHash(witness_script)));
1103 tx_create_segwit.vout.emplace_back(141414, GetScriptForDestination(WitnessV1Taproot{XOnlyPubKey(key.GetPubKey())}));
1104 prev_txid = tx_create_segwit.GetHash();
1105 for (unsigned i{0}; i < tx_create_segwit.vout.size(); ++i) {
1106 tx_max_sigops.vin.emplace_back(prev_txid, i);
1107 }
1108
1109 // The transaction now still contains exactly 2500 sigops, the check should pass.
1110 AddCoins(coins, CTransaction(tx_create_segwit), 0, false);
1111 BOOST_REQUIRE(::ValidateInputsStandardness(CTransaction(tx_max_sigops), coins).IsValid());
1112
1113 // Add one more P2PK input. We'll reach the limit.
1114 tx_create_p2pk.vout.emplace_back(212121, p2pk_script);
1115 prev_txid = tx_create_p2pk.GetHash();
1116 tx_max_sigops.vin.resize(p2sh_inputs_count);
1117 ++p2pk_inputs_count;
1118 for (unsigned i{0}; i < p2pk_inputs_count; ++i) {
1119 tx_max_sigops.vin.emplace_back(prev_txid, i);
1120 }
1121 AddCoins(coins, CTransaction(tx_create_p2pk), 0, false);
1122 auto legacy_sigop_count_p2pk = p2sh_inputs_count * MAX_P2SH_SIGOPS + p2pk_inputs_count * 1;
1123 BOOST_CHECK_GT(legacy_sigop_count_p2pk, MAX_TX_LEGACY_SIGOPS);
1124 {
1125 auto validation_state = ValidateInputsStandardness(CTransaction(tx_max_sigops), coins);
1126 BOOST_CHECK(validation_state.IsInvalid());
1127 BOOST_CHECK_EQUAL(validation_state.GetRejectReason(), reject_reason);
1128 BOOST_CHECK_EQUAL(validation_state.GetDebugMessage(), sigop_limit_reject_debug_message);
1129 }
1130}
1131
1132BOOST_AUTO_TEST_CASE(getlegacysigopcount_inaccurate_test)
1133{
1134 // Legacy sigops are counted inaccurately in both the scriptSig and the
1135 // scriptPubKey: a CHECKMULTISIG counts as MAX_PUBKEYS_PER_MULTISIG even when the
1136 // preceding OP_N says it takes fewer keys. Counting it accurately would
1137 // undercount, letting a block over the sigop limit through.
1138 const CScript multisig{CScript() << OP_1 << OP_CHECKMULTISIG};
1139
1141 mtx.vin.emplace_back(COutPoint{}, multisig);
1143
1144 mtx.vout.emplace_back(0, multisig);
1146}
1147
1148BOOST_AUTO_TEST_CASE(checktxinputs_invalid_transactions_test)
1149{
1150 auto check_invalid{[](CAmount input_value, CAmount output_value, bool coinbase, int spend_height, TxValidationResult expected_result, std::string_view expected_reason) {
1152
1153 const COutPoint prevout{Txid::FromUint256(uint256::ONE), 0};
1154 inputs.AddCoin(prevout, Coin{{input_value, CScript() << OP_TRUE}, /*nHeightIn=*/1, coinbase}, /*possible_overwrite=*/false);
1155
1157 mtx.vin.emplace_back(prevout);
1158 mtx.vout.emplace_back(output_value, CScript() << OP_TRUE);
1159
1160 TxValidationState state;
1161 CAmount txfee{0};
1162 BOOST_CHECK(!Consensus::CheckTxInputs(CTransaction{mtx}, state, inputs, spend_height, txfee));
1163 BOOST_CHECK(state.IsInvalid());
1165 BOOST_CHECK_EQUAL(state.GetRejectReason(), expected_reason);
1166 }};
1167
1168 check_invalid(/*input_value=*/MAX_MONEY + 1,
1169 /*output_value=*/0,
1170 /*coinbase=*/false,
1171 /*spend_height=*/2,
1172 TxValidationResult::TX_CONSENSUS, /*expected_reason=*/"bad-txns-inputvalues-outofrange");
1173
1174 check_invalid(/*input_value=*/1 * COIN,
1175 /*output_value=*/2 * COIN,
1176 /*coinbase=*/false,
1177 /*spend_height=*/2,
1178 TxValidationResult::TX_CONSENSUS, /*expected_reason=*/"bad-txns-in-belowout");
1179
1180 check_invalid(/*input_value=*/1 * COIN,
1181 /*output_value=*/0,
1182 /*coinbase=*/true,
1183 /*spend_height=*/COINBASE_MATURITY,
1184 TxValidationResult::TX_PREMATURE_SPEND, /*expected_reason=*/"bad-txns-premature-spend-of-coinbase");
1185}
1186
1187BOOST_AUTO_TEST_CASE(isfinaltx_sequences_test)
1188{
1189 constexpr int height{100};
1190
1191 // Every transaction here has the same unsatisfied nLockTime, so only the
1192 // sequences decide the outcome.
1193 auto check_final{[](const std::vector<uint32_t>& sequences, bool expected_final) {
1195 mtx.nLockTime = height;
1196 for (const uint32_t sequence : sequences) {
1197 mtx.vin.emplace_back(COutPoint{}, CScript{}, sequence);
1198 }
1199
1200 BOOST_CHECK_EQUAL(IsFinalTx(CTransaction{mtx}, /*nBlockHeight=*/height, /*nBlockTime=*/0), expected_final);
1201 }};
1202
1203 check_final(/*sequences=*/{CTxIn::SEQUENCE_FINAL, CTxIn::SEQUENCE_FINAL}, /*expected_final=*/true);
1204
1205 // nLockTime is only ignored when every input is SEQUENCE_FINAL
1206 check_final(/*sequences=*/{CTxIn::SEQUENCE_FINAL, CTxIn::MAX_SEQUENCE_NONFINAL}, /*expected_final=*/false);
1207 check_final(/*sequences=*/{CTxIn::MAX_SEQUENCE_NONFINAL, CTxIn::SEQUENCE_FINAL}, /*expected_final=*/false);
1208}
1209
1210BOOST_AUTO_TEST_CASE(calculatesequencelocks_tx_version_test)
1211{
1212 constexpr int coin_height{100};
1213
1214 // A single input with a height-based relative locktime of one block. Only the
1215 // height branch is taken, so the block index is never dereferenced.
1216 auto check_min_height{[](uint32_t version, int expected_min_height) {
1218 mtx.version = version;
1219 mtx.vin.emplace_back(COutPoint{}, CScript{}, /*nSequenceIn=*/1);
1220
1221 std::vector<int> prev_heights{coin_height};
1222 const CBlockIndex block{};
1223 const auto lock_pair{CalculateSequenceLocks(CTransaction{mtx}, LOCKTIME_VERIFY_SEQUENCE, prev_heights, block)};
1224 BOOST_CHECK_EQUAL(lock_pair.first, expected_min_height);
1225 }};
1226
1227 // BIP68 only applies to versions 2 and up
1228 check_min_height(/*version=*/0, /*expected_min_height=*/-1);
1229 check_min_height(/*version=*/1, /*expected_min_height=*/-1);
1230 check_min_height(/*version=*/2, /*expected_min_height=*/coin_height);
1231 check_min_height(/*version=*/std::numeric_limits<uint32_t>::max(), /*expected_min_height=*/coin_height);
1232}
1233
1234BOOST_AUTO_TEST_CASE(getvalueout_out_of_range_throws)
1235{
1237 mtx.vout.emplace_back(MAX_MONEY + 1, CScript() << OP_TRUE);
1238
1239 const CTransaction tx{mtx};
1240 BOOST_CHECK_EXCEPTION(tx.GetValueOut(), std::runtime_error, HasReason("GetValueOut: value out of range"));
1241}
1242
1244BOOST_AUTO_TEST_CASE(spends_witness_prog)
1245{
1247 CKey key;
1248 key.MakeNewKey(true);
1249 const CPubKey pubkey{key.GetPubKey()};
1250 CMutableTransaction tx_create{}, tx_spend{};
1251 tx_create.vout.emplace_back(0, CScript{});
1252 tx_spend.vin.emplace_back(Txid{}, 0);
1253 std::vector<std::vector<uint8_t>> sol_dummy;
1254
1255 // CNoDestination, PubKeyDestination, PKHash, ScriptHash, WitnessV0ScriptHash, WitnessV0KeyHash,
1256 // WitnessV1Taproot, PayToAnchor, WitnessUnknown.
1257 static_assert(std::variant_size_v<CTxDestination> == 9);
1258
1259 // Go through all defined output types and sanity check SpendsNonAnchorWitnessProg.
1260
1261 // P2PK
1262 tx_create.vout[0].scriptPubKey = GetScriptForDestination(PubKeyDestination{pubkey});
1263 BOOST_CHECK_EQUAL(Solver(tx_create.vout[0].scriptPubKey, sol_dummy), TxoutType::PUBKEY);
1264 tx_spend.vin[0].prevout.hash = tx_create.GetHash();
1265 AddCoins(coins, CTransaction{tx_create}, 0, false);
1267
1268 // P2PKH
1269 tx_create.vout[0].scriptPubKey = GetScriptForDestination(PKHash{pubkey});
1270 BOOST_CHECK_EQUAL(Solver(tx_create.vout[0].scriptPubKey, sol_dummy), TxoutType::PUBKEYHASH);
1271 tx_spend.vin[0].prevout.hash = tx_create.GetHash();
1272 AddCoins(coins, CTransaction{tx_create}, 0, false);
1274
1275 // P2SH
1276 auto redeem_script{CScript{} << OP_1 << OP_CHECKSIG};
1277 tx_create.vout[0].scriptPubKey = GetScriptForDestination(ScriptHash{redeem_script});
1278 BOOST_CHECK_EQUAL(Solver(tx_create.vout[0].scriptPubKey, sol_dummy), TxoutType::SCRIPTHASH);
1279 tx_spend.vin[0].prevout.hash = tx_create.GetHash();
1280 tx_spend.vin[0].scriptSig = CScript{} << OP_0 << ToByteVector(redeem_script);
1281 AddCoins(coins, CTransaction{tx_create}, 0, false);
1283 tx_spend.vin[0].scriptSig.clear();
1284
1285 // native P2WSH
1286 const auto witness_script{CScript{} << OP_12 << OP_HASH160 << OP_DUP << OP_EQUAL};
1287 tx_create.vout[0].scriptPubKey = GetScriptForDestination(WitnessV0ScriptHash{witness_script});
1288 BOOST_CHECK_EQUAL(Solver(tx_create.vout[0].scriptPubKey, sol_dummy), TxoutType::WITNESS_V0_SCRIPTHASH);
1289 tx_spend.vin[0].prevout.hash = tx_create.GetHash();
1290 AddCoins(coins, CTransaction{tx_create}, 0, false);
1292
1293 // P2SH-wrapped P2WSH
1294 redeem_script = tx_create.vout[0].scriptPubKey;
1295 tx_create.vout[0].scriptPubKey = GetScriptForDestination(ScriptHash(redeem_script));
1296 BOOST_CHECK_EQUAL(Solver(tx_create.vout[0].scriptPubKey, sol_dummy), TxoutType::SCRIPTHASH);
1297 tx_spend.vin[0].prevout.hash = tx_create.GetHash();
1298 tx_spend.vin[0].scriptSig = CScript{} << ToByteVector(redeem_script);
1299 AddCoins(coins, CTransaction{tx_create}, 0, false);
1301 tx_spend.vin[0].scriptSig.clear();
1303
1304 // native P2WPKH
1305 tx_create.vout[0].scriptPubKey = GetScriptForDestination(WitnessV0KeyHash{pubkey});
1306 BOOST_CHECK_EQUAL(Solver(tx_create.vout[0].scriptPubKey, sol_dummy), TxoutType::WITNESS_V0_KEYHASH);
1307 tx_spend.vin[0].prevout.hash = tx_create.GetHash();
1308 AddCoins(coins, CTransaction{tx_create}, 0, false);
1310
1311 // P2SH-wrapped P2WPKH
1312 redeem_script = tx_create.vout[0].scriptPubKey;
1313 tx_create.vout[0].scriptPubKey = GetScriptForDestination(ScriptHash(redeem_script));
1314 BOOST_CHECK_EQUAL(Solver(tx_create.vout[0].scriptPubKey, sol_dummy), TxoutType::SCRIPTHASH);
1315 tx_spend.vin[0].prevout.hash = tx_create.GetHash();
1316 tx_spend.vin[0].scriptSig = CScript{} << ToByteVector(redeem_script);
1317 AddCoins(coins, CTransaction{tx_create}, 0, false);
1319 tx_spend.vin[0].scriptSig.clear();
1321
1322 // P2TR
1323 tx_create.vout[0].scriptPubKey = GetScriptForDestination(WitnessV1Taproot{XOnlyPubKey{pubkey}});
1324 BOOST_CHECK_EQUAL(Solver(tx_create.vout[0].scriptPubKey, sol_dummy), TxoutType::WITNESS_V1_TAPROOT);
1325 tx_spend.vin[0].prevout.hash = tx_create.GetHash();
1326 AddCoins(coins, CTransaction{tx_create}, 0, false);
1328
1329 // P2SH-wrapped P2TR (undefined, non-standard)
1330 redeem_script = tx_create.vout[0].scriptPubKey;
1331 tx_create.vout[0].scriptPubKey = GetScriptForDestination(ScriptHash(redeem_script));
1332 BOOST_CHECK_EQUAL(Solver(tx_create.vout[0].scriptPubKey, sol_dummy), TxoutType::SCRIPTHASH);
1333 tx_spend.vin[0].prevout.hash = tx_create.GetHash();
1334 tx_spend.vin[0].scriptSig = CScript{} << ToByteVector(redeem_script);
1335 AddCoins(coins, CTransaction{tx_create}, 0, false);
1337 tx_spend.vin[0].scriptSig.clear();
1339
1340 // P2A
1341 tx_create.vout[0].scriptPubKey = GetScriptForDestination(PayToAnchor{});
1342 BOOST_CHECK_EQUAL(Solver(tx_create.vout[0].scriptPubKey, sol_dummy), TxoutType::ANCHOR);
1343 tx_spend.vin[0].prevout.hash = tx_create.GetHash();
1344 AddCoins(coins, CTransaction{tx_create}, 0, false);
1346
1347 // P2SH-wrapped P2A (undefined, non-standard)
1348 redeem_script = tx_create.vout[0].scriptPubKey;
1349 tx_create.vout[0].scriptPubKey = GetScriptForDestination(ScriptHash(redeem_script));
1350 BOOST_CHECK_EQUAL(Solver(tx_create.vout[0].scriptPubKey, sol_dummy), TxoutType::SCRIPTHASH);
1351 tx_spend.vin[0].prevout.hash = tx_create.GetHash();
1352 tx_spend.vin[0].scriptSig = CScript{} << ToByteVector(redeem_script);
1353 AddCoins(coins, CTransaction{tx_create}, 0, false);
1355 tx_spend.vin[0].scriptSig.clear();
1356
1357 // Undefined version 1 witness program
1358 tx_create.vout[0].scriptPubKey = GetScriptForDestination(WitnessUnknown{1, {0x42, 0x42}});
1359 BOOST_CHECK_EQUAL(Solver(tx_create.vout[0].scriptPubKey, sol_dummy), TxoutType::WITNESS_UNKNOWN);
1360 tx_spend.vin[0].prevout.hash = tx_create.GetHash();
1361 AddCoins(coins, CTransaction{tx_create}, 0, false);
1363
1364 // P2SH-wrapped undefined version 1 witness program
1365 redeem_script = tx_create.vout[0].scriptPubKey;
1366 tx_create.vout[0].scriptPubKey = GetScriptForDestination(ScriptHash(redeem_script));
1367 BOOST_CHECK_EQUAL(Solver(tx_create.vout[0].scriptPubKey, sol_dummy), TxoutType::SCRIPTHASH);
1368 tx_spend.vin[0].prevout.hash = tx_create.GetHash();
1369 tx_spend.vin[0].scriptSig = CScript{} << ToByteVector(redeem_script);
1370 AddCoins(coins, CTransaction{tx_create}, 0, false);
1372 tx_spend.vin[0].scriptSig.clear();
1374
1375 // Various undefined version >1 32-byte witness programs.
1376 const auto program{ToByteVector(XOnlyPubKey{pubkey})};
1377 for (int i{2}; i <= 16; ++i) {
1378 tx_create.vout[0].scriptPubKey = GetScriptForDestination(WitnessUnknown{i, program});
1379 BOOST_CHECK_EQUAL(Solver(tx_create.vout[0].scriptPubKey, sol_dummy), TxoutType::WITNESS_UNKNOWN);
1380 tx_spend.vin[0].prevout.hash = tx_create.GetHash();
1381 AddCoins(coins, CTransaction{tx_create}, 0, false);
1383
1384 // It's also detected within P2SH.
1385 redeem_script = tx_create.vout[0].scriptPubKey;
1386 tx_create.vout[0].scriptPubKey = GetScriptForDestination(ScriptHash(redeem_script));
1387 BOOST_CHECK_EQUAL(Solver(tx_create.vout[0].scriptPubKey, sol_dummy), TxoutType::SCRIPTHASH);
1388 tx_spend.vin[0].prevout.hash = tx_create.GetHash();
1389 tx_spend.vin[0].scriptSig = CScript{} << ToByteVector(redeem_script);
1390 AddCoins(coins, CTransaction{tx_create}, 0, false);
1392 tx_spend.vin[0].scriptSig.clear();
1394 }
1395}
1396
std::vector< unsigned char > valtype
Definition: addresstype.cpp:18
CScript GetScriptForDestination(const CTxDestination &dest)
Generate a Bitcoin scriptPubKey for the given CTxDestination.
const std::vector< unsigned char > ANCHOR_BYTES
Witness program for Pay-to-Anchor output script type.
Definition: addresstype.h:121
constexpr CAmount MAX_MONEY
No amount larger than this (in satoshi) is valid.
Definition: amount.h:26
int64_t CAmount
Amount in satoshis (Can be negative)
Definition: amount.h:12
constexpr CAmount COIN
The amount of satoshis in one BTC.
Definition: amount.h:15
int ret
int flags
Definition: bitcoin-tx.cpp:530
#define Assert(val)
Identity function.
Definition: check.h:116
The block chain is a tree shaped structure starting with the genesis block at the root,...
Definition: chain.h:94
RAII-style controller object for a CCheckQueue that guarantees the passed queue is finished before co...
Definition: checkqueue.h:210
std::optional< R > Complete()
Definition: checkqueue.h:222
void Add(std::vector< T > &&vChecks)
Definition: checkqueue.h:229
CCoinsView that adds a memory cache for transactions to another CCoinsView.
Definition: coins.h:437
Fee rate in satoshis per virtualbyte: CAmount / vB the feerate is represented internally as FeeFrac.
Definition: feerate.h:32
CAmount GetFeePerK() const
Return the fee in satoshis for a vsize of 1000 vbytes.
Definition: feerate.h:71
An encapsulated private key.
Definition: key.h:40
void MakeNewKey(bool fCompressed)
Generate a new private key using a cryptographic PRNG.
Definition: key.cpp:163
CPubKey GetPubKey() const
Compute the public key from a private key.
Definition: key.cpp:184
A reference to a CKey: the Hash160 of its serialized public key.
Definition: pubkey.h:26
An outpoint - a combination of a transaction hash and an index n into its vout.
Definition: transaction.h:30
An encapsulated public key.
Definition: pubkey.h:40
CKeyID GetID() const
Get the KeyID of this public key (hash of its serialization)
Definition: pubkey.h:166
Serialized script, used inside transaction inputs and outputs.
Definition: script.h:406
static opcodetype EncodeOP_N(int n)
Definition: script.h:515
The basic transaction that is broadcasted on the network and contained in blocks.
Definition: transaction.h:287
const std::vector< CTxOut > vout
Definition: transaction.h:298
const std::vector< CTxIn > vin
Definition: transaction.h:297
An input of a transaction.
Definition: transaction.h:63
static constexpr uint32_t SEQUENCE_FINAL
Setting nSequence to this value for every input in a transaction disables nLockTime/IsFinalTx().
Definition: transaction.h:77
CScript scriptSig
Definition: transaction.h:66
CScriptWitness scriptWitness
Only serialized through CTransaction.
Definition: transaction.h:68
static constexpr uint32_t MAX_SEQUENCE_NONFINAL
This is the maximum sequence number that enables both nLockTime and OP_CHECKLOCKTIMEVERIFY (BIP 65).
Definition: transaction.h:83
COutPoint prevout
Definition: transaction.h:65
CScript scriptPubKey
Definition: transaction.h:144
CAmount nValue
Definition: transaction.h:143
A UTXO entry.
Definition: coins.h:46
CTxOut out
unspent transaction output
Definition: coins.h:49
bool fCoinBase
whether containing transaction was a coinbase
Definition: coins.h:52
uint32_t nHeight
at which height this containing transaction was included in the active block chain
Definition: coins.h:55
static CoinsViewEmpty & Get()
Definition: coins.cpp:29
Double ended buffer combining vector and stream-like interfaces.
Definition: streams.h:165
Fillable signing provider that keeps keys in an address->secret map.
virtual bool AddKeyPubKey(const CKey &key, const CPubKey &pubkey)
virtual bool AddCScript(const CScript &redeemScript)
BOOST_CHECK_EXCEPTION predicates to check the specific validation error.
Definition: common.h:19
A signature creator for transactions.
Definition: sign.h:54
Valid signature cache, to avoid doing expensive ECDSA signature checking twice for every transaction ...
Definition: sigcache.h:40
Minimal stream for reading from an existing byte array by std::span.
Definition: streams.h:83
const std::string & get_str() const
bool isArray() const
Definition: univalue.h:87
std::string write(unsigned int prettyIndent=0, unsigned int indentLevel=0) const
size_t size() const
Definition: univalue.h:71
bool isStr() const
Definition: univalue.h:85
Int getInt() const
Definition: univalue.h:143
const UniValue & get_array() const
bool IsValid() const
Definition: validation.h:112
std::string GetRejectReason() const
Definition: validation.h:116
Result GetResult() const
Definition: validation.h:115
bool IsInvalid() const
Definition: validation.h:113
constexpr unsigned char * end()
Definition: uint256.h:102
constexpr unsigned char * begin()
Definition: uint256.h:101
void emplace_back(Args &&... args)
Definition: prevector.h:383
iterator begin()
Definition: prevector.h:255
iterator end()
Definition: prevector.h:257
static constexpr script_verify_flags from_int(value_type f)
Definition: verify_flags.h:35
static transaction_identifier FromUint256(const uint256 &id)
static std::optional< transaction_identifier > FromHex(std::string_view hex)
static const uint256 ONE
Definition: uint256.h:205
void AddCoins(CCoinsViewCache &cache, const CTransaction &tx, int nHeight, bool check_for_overwrite)
Utility function to add all of a transaction's outputs to a cache.
Definition: coins.cpp:133
static int32_t GetTransactionWeight(const CTransaction &tx)
Definition: validation.h:139
TxValidationResult
A "reason" why a transaction was invalid, suitable for determining whether the provider of the transa...
Definition: validation.h:30
@ TX_PREMATURE_SPEND
transaction spends a coinbase too early, or violates locktime/sequence locks
@ TX_CONSENSUS
invalid by consensus rules
constexpr unsigned int LOCKTIME_VERIFY_SEQUENCE
Flags for nSequence and nLockTime locks.
Definition: consensus.h:28
constexpr int COINBASE_MATURITY
Coinbase transaction outputs can only be spent after this number of new blocks (network rule)
Definition: consensus.h:19
constexpr unsigned int MAX_BLOCK_WEIGHT
The maximum allowed weight for a block, see BIP 141 (network rule)
Definition: consensus.h:15
constexpr int WITNESS_SCALE_FACTOR
Definition: consensus.h:21
CScript ParseScript(const std::string &s)
Definition: core_io.cpp:92
BOOST_FIXTURE_TEST_SUITE(cuckoocache_tests, BasicTestingSetup)
Test Suite for CuckooCache.
BOOST_AUTO_TEST_SUITE_END()
BOOST_CHECK_GT(excessive_headers.size(), MAX_HEADERS_SIZE)
BOOST_CHECK_EQUAL(headers.FindFirst("key"), "value")
BOOST_CHECK_EXCEPTION(HTTPHeaders{}.Read(reader), std::runtime_error, HasReason{"Empty HTTP header name"})
const std::map< std::string, script_verify_flag_name > & ScriptFlagNamesToEnum()
bool EvalScript(std::vector< std::vector< unsigned char > > &stack, const CScript &script, script_verify_flags flags, const BaseSignatureChecker &checker, SigVersion sigversion, ScriptExecutionData &execdata, ScriptError *serror)
bool VerifyScript(const CScript &scriptSig, const CScript &scriptPubKey, const CScriptWitness *witness, script_verify_flags flags, const BaseSignatureChecker &checker, ScriptError *serror)
constexpr int MAX_SCRIPT_VERIFY_FLAGS_BITS
Definition: interpreter.h:155
@ BASE
Bare scripts and BIP16 P2SH-wrapped redeemscripts.
@ SIGHASH_ANYONECANPAY
Definition: interpreter.h:35
@ SIGHASH_ALL
Definition: interpreter.h:32
@ SIGHASH_NONE
Definition: interpreter.h:33
@ SIGHASH_SINGLE
Definition: interpreter.h:34
@ ASSERT_FAIL
Abort execution through assertion failure (for consensus code)
constexpr script_verify_flags SCRIPT_VERIFY_NONE
Script verification flags.
Definition: interpreter.h:48
UniValue read_json(std::string_view jsondata)
Definition: json.cpp:12
CKey GenerateRandomKey(bool compressed) noexcept
Definition: key.cpp:354
uint64_t sequence
bool CheckTxInputs(const CTransaction &tx, TxValidationState &state, const CCoinsViewCache &inputs, int nSpendHeight, CAmount &txfee)
Check whether all inputs of this transaction are valid (no double spends and amounts) This does not m...
Definition: tx_verify.cpp:170
""_hex is a compile-time user-defined literal returning a std::array<std::byte>, equivalent to ParseH...
Definition: strencodings.h:386
std::vector< std::string > SplitString(std::string_view str, char sep)
Definition: string.h:153
std::string ToString(const T &t)
Locale-independent version of std::to_string.
Definition: string.h:250
#define BOOST_CHECK(expr)
Definition: object.cpp:16
TxValidationState ValidateInputsStandardness(const CTransaction &tx, const CCoinsViewCache &mapInputs)
Check transaction inputs.
Definition: policy.cpp:214
bool SpendsNonAnchorWitnessProg(const CTransaction &tx, const CCoinsViewCache &prevouts)
Check whether this transaction spends any witness program but P2A, including not-yet-defined ones.
Definition: policy.cpp:354
bool IsStandardTx(const CTransaction &tx, const std::optional< unsigned > &max_datacarrier_bytes, bool permit_bare_multisig, const CFeeRate &dust_relay_fee, std::string &reason)
Check for standard transaction types.
Definition: policy.cpp:100
constexpr unsigned int MAX_OP_RETURN_RELAY
Default setting for -datacarriersize in vbytes.
Definition: policy.h:84
constexpr unsigned int MAX_TX_LEGACY_SIGOPS
The maximum number of potentially executed legacy signature operations in a single standard tx.
Definition: policy.h:46
constexpr script_verify_flags STANDARD_SCRIPT_VERIFY_FLAGS
Standard script verification flags that standard transactions will comply with.
Definition: policy.h:118
constexpr decltype(CTransaction::version) TX_MAX_STANDARD_VERSION
Definition: policy.h:152
constexpr bool DEFAULT_PERMIT_BAREMULTISIG
Default for -permitbaremultisig.
Definition: policy.h:52
constexpr unsigned int DUST_RELAY_TX_FEE
Min feerate for defining dust.
Definition: policy.h:68
constexpr unsigned int MAX_DUST_OUTPUTS_PER_TX
Maximum number of ephemeral dust outputs allowed.
Definition: policy.h:95
constexpr unsigned int MAX_P2SH_SIGOPS
Maximum number of signature check operations in an IsStandard() P2SH script.
Definition: policy.h:42
constexpr TransactionSerParams TX_NO_WITNESS
Definition: transaction.h:182
constexpr TransactionSerParams TX_WITH_WITNESS
Definition: transaction.h:181
std::shared_ptr< const CTransaction > CTransactionRef
Definition: transaction.h:417
const char * name
Definition: rest.cpp:71
opcodetype
Script opcodes.
Definition: script.h:75
@ OP_PUSHDATA4
Definition: script.h:81
@ OP_CHECKMULTISIG
Definition: script.h:193
@ OP_IF
Definition: script.h:105
@ OP_ROT
Definition: script.h:131
@ OP_1NEGATE
Definition: script.h:82
@ OP_CHECKSIG
Definition: script.h:191
@ OP_CHECKLOCKTIMEVERIFY
Definition: script.h:198
@ OP_16
Definition: script.h:100
@ OP_NOT
Definition: script.h:159
@ OP_EQUAL
Definition: script.h:147
@ OP_SIZE
Definition: script.h:140
@ OP_3DUP
Definition: script.h:119
@ OP_DUP
Definition: script.h:126
@ OP_NOP
Definition: script.h:103
@ OP_CODESEPARATOR
Definition: script.h:190
@ OP_HASH256
Definition: script.h:189
@ OP_SUB
Definition: script.h:163
@ OP_HASH160
Definition: script.h:188
@ OP_2DUP
Definition: script.h:118
@ OP_1
Definition: script.h:84
@ OP_TRUE
Definition: script.h:85
@ OP_VERIFY
Definition: script.h:111
@ OP_12
Definition: script.h:96
@ OP_ADD
Definition: script.h:162
@ OP_DROP
Definition: script.h:125
@ OP_9
Definition: script.h:93
@ OP_0
Definition: script.h:77
@ OP_RETURN
Definition: script.h:112
@ OP_EQUALVERIFY
Definition: script.h:148
@ OP_RESERVED
Definition: script.h:83
constexpr int MAX_PUBKEYS_PER_MULTISIG
Definition: script.h:35
std::vector< unsigned char > ToByteVector(const T &in)
Definition: script.h:68
std::string ScriptErrorString(const ScriptError serror)
enum ScriptError_t ScriptError
@ SCRIPT_ERR_UNKNOWN_ERROR
Definition: script_error.h:14
@ SCRIPT_ERR_OK
Definition: script_error.h:13
static const int64_t values[]
A selection of numbers that do not trigger int64_t overflow when added/subtracted.
constexpr deserialize_type deserialize
Definition: serialize.h:52
uint64_t GetSerializeSize(const T &t)
Definition: serialize.h:1157
constexpr CAmount CENT
Definition: setup_common.h:41
constexpr size_t DEFAULT_SIGNATURE_CACHE_BYTES
Definition: sigcache.h:30
bool ProduceSignature(const SigningProvider &provider, const BaseSignatureCreator &creator, const CScript &fromPubKey, SignatureData &sigdata)
Produce a script signature using a generic signature creator.
Definition: sign.cpp:745
void UpdateInput(CTxIn &input, const SignatureData &data)
Definition: sign.cpp:918
SignatureData DataFromTransaction(const CMutableTransaction &tx, unsigned int nIn, const CTxOut &txout)
Extract signature data from a transaction input, and insert it.
Definition: sign.cpp:853
const SigningProvider & DUMMY_SIGNING_PROVIDER
TxoutType Solver(const CScript &scriptPubKey, std::vector< std::vector< unsigned char > > &vSolutionsRet)
Parse a scriptPubKey and identify script type for standard scripts.
Definition: solver.cpp:141
CScript GetScriptForMultisig(int nRequired, const std::vector< CPubKey > &keys)
Generate a multisig script.
Definition: solver.cpp:218
@ WITNESS_V1_TAPROOT
@ WITNESS_UNKNOWN
Only for Witness versions not already defined above.
@ ANCHOR
anyone can spend script
@ WITNESS_V0_SCRIPTHASH
@ WITNESS_V0_KEYHASH
std::vector< Byte > ParseHex(std::string_view hex_str)
Like TryParseHex, but returns an empty vector on invalid input.
Definition: strencodings.h:69
Basic testing setup.
Definition: setup_common.h:58
A mutable version of CTransaction.
Definition: transaction.h:372
std::vector< CTxOut > vout
Definition: transaction.h:374
Txid GetHash() const
Compute the hash of this CMutableTransaction.
Definition: transaction.cpp:69
std::vector< CTxIn > vin
Definition: transaction.h:373
void MergeSignatureData(SignatureData sigdata)
Definition: sign.cpp:924
CTxDestination subtype to encode any future Witness version.
Definition: addresstype.h:96
bool IsValidFlagCombination(script_verify_flags flags)
Flags that are not forbidden by an assert in script validation.
Definition: script.cpp:8
SignatureData CombineSignatures(const CMutableTransaction &input1, const CMutableTransaction &input2, const CTransactionRef tx)
std::set< script_verify_flags > ExcludeIndividualFlags(script_verify_flags flags)
script_verify_flags FillFlags(script_verify_flags flags)
bool CheckTxScripts(const CTransaction &tx, const std::map< COutPoint, CScript > &map_prevout_scriptPubKeys, const std::map< COutPoint, int64_t > &map_prevout_values, script_verify_flags flags, const PrecomputedTransactionData &txdata, const std::string &strTest, bool expect_valid)
static bool g_bare_multi
static const std::map< std::string, script_verify_flag_name > & mapFlagNames
script_verify_flags TrimFlags(script_verify_flags flags)
std::vector< unsigned char > valtype
BOOST_AUTO_TEST_CASE(tx_valid)
script_verify_flags ParseScriptFlags(std::string strFlags)
static void ReplaceRedeemScript(CScript &script, const CScript &redeemScript)
bool CheckMapFlagNames()
static void CreateCreditAndSpend(const FillableSigningProvider &keystore, const CScript &outscript, CTransactionRef &output, CMutableTransaction &input, bool success=true)
static CScript PushAll(const std::vector< valtype > &values)
static CFeeRate g_dust
static void CheckWithFlag(const CTransactionRef &output, const CMutableTransaction &input, script_verify_flags flags, bool success)
std::vector< CMutableTransaction > SetupDummyInputs(FillableSigningProvider &keystoreRet, CCoinsViewCache &coinsRet, const std::array< CAmount, 4 > &nValues)
bool SignSignature(const SigningProvider &provider, const CScript &fromPubKey, CMutableTransaction &txTo, unsigned int nIn, const CAmount &amount, int nHashType, SignatureData &sig_data)
Produce a satisfying script (scriptSig or witness).
bool CheckTransaction(const CTransaction &tx, TxValidationState &state)
Definition: tx_check.cpp:19
std::pair< int, int64_t > CalculateSequenceLocks(const CTransaction &tx, int flags, std::vector< int > &prevHeights, const CBlockIndex &block)
Calculates the block height and previous block's median time past at which the transaction will be co...
Definition: tx_verify.cpp:45
unsigned int GetLegacySigOpCount(const CTransaction &tx)
Auxiliary functions for transaction validation (ideally should not be exposed)
Definition: tx_verify.cpp:118
unsigned int GetP2SHSigOpCount(const CTransaction &tx, const CCoinsViewCache &inputs)
Count ECDSA signature operations in pay-to-script-hash inputs.
Definition: tx_verify.cpp:132
bool IsFinalTx(const CTransaction &tx, int nBlockHeight, int64_t nBlockTime)
Check if transaction is final and can be included in a block with the specified height and time.
Definition: tx_verify.cpp:23
constexpr std::array tests
Definition: unitester.cpp:101
assert(!tx.IsCoinBase())