Bitcoin Core 29.99.0
P2P Digital Currency
transaction_tests.cpp
Go to the documentation of this file.
1// Copyright (c) 2011-2022 The Bitcoin Core developers
2// Distributed under the MIT software license, see the accompanying
3// file COPYING or http://www.opensource.org/licenses/mit-license.php.
4
5#include <test/data/tx_invalid.json.h>
6#include <test/data/tx_valid.json.h>
8
9#include <checkqueue.h>
10#include <clientversion.h>
11#include <consensus/amount.h>
12#include <consensus/tx_check.h>
13#include <consensus/tx_verify.h>
15#include <core_io.h>
16#include <key.h>
17#include <policy/policy.h>
18#include <policy/settings.h>
20#include <script/script.h>
21#include <script/script_error.h>
22#include <script/sigcache.h>
23#include <script/sign.h>
25#include <script/solver.h>
26#include <streams.h>
27#include <test/util/json.h>
28#include <test/util/random.h>
29#include <test/util/script.h>
31#include <util/strencodings.h>
32#include <util/string.h>
33#include <validation.h>
34
35#include <functional>
36#include <map>
37#include <string>
38
39#include <boost/test/unit_test.hpp>
40
41#include <univalue.h>
42
43using namespace util::hex_literals;
45using util::ToString;
46
47typedef std::vector<unsigned char> valtype;
48
51
52static std::map<std::string, unsigned int> mapFlagNames = {
53 {std::string("P2SH"), (unsigned int)SCRIPT_VERIFY_P2SH},
54 {std::string("STRICTENC"), (unsigned int)SCRIPT_VERIFY_STRICTENC},
55 {std::string("DERSIG"), (unsigned int)SCRIPT_VERIFY_DERSIG},
56 {std::string("LOW_S"), (unsigned int)SCRIPT_VERIFY_LOW_S},
57 {std::string("SIGPUSHONLY"), (unsigned int)SCRIPT_VERIFY_SIGPUSHONLY},
58 {std::string("MINIMALDATA"), (unsigned int)SCRIPT_VERIFY_MINIMALDATA},
59 {std::string("NULLDUMMY"), (unsigned int)SCRIPT_VERIFY_NULLDUMMY},
60 {std::string("DISCOURAGE_UPGRADABLE_NOPS"), (unsigned int)SCRIPT_VERIFY_DISCOURAGE_UPGRADABLE_NOPS},
61 {std::string("CLEANSTACK"), (unsigned int)SCRIPT_VERIFY_CLEANSTACK},
62 {std::string("MINIMALIF"), (unsigned int)SCRIPT_VERIFY_MINIMALIF},
63 {std::string("NULLFAIL"), (unsigned int)SCRIPT_VERIFY_NULLFAIL},
64 {std::string("CHECKLOCKTIMEVERIFY"), (unsigned int)SCRIPT_VERIFY_CHECKLOCKTIMEVERIFY},
65 {std::string("CHECKSEQUENCEVERIFY"), (unsigned int)SCRIPT_VERIFY_CHECKSEQUENCEVERIFY},
66 {std::string("WITNESS"), (unsigned int)SCRIPT_VERIFY_WITNESS},
67 {std::string("DISCOURAGE_UPGRADABLE_WITNESS_PROGRAM"), (unsigned int)SCRIPT_VERIFY_DISCOURAGE_UPGRADABLE_WITNESS_PROGRAM},
68 {std::string("WITNESS_PUBKEYTYPE"), (unsigned int)SCRIPT_VERIFY_WITNESS_PUBKEYTYPE},
69 {std::string("CONST_SCRIPTCODE"), (unsigned int)SCRIPT_VERIFY_CONST_SCRIPTCODE},
70 {std::string("TAPROOT"), (unsigned int)SCRIPT_VERIFY_TAPROOT},
71 {std::string("DISCOURAGE_UPGRADABLE_PUBKEYTYPE"), (unsigned int)SCRIPT_VERIFY_DISCOURAGE_UPGRADABLE_PUBKEYTYPE},
72 {std::string("DISCOURAGE_OP_SUCCESS"), (unsigned int)SCRIPT_VERIFY_DISCOURAGE_OP_SUCCESS},
73 {std::string("DISCOURAGE_UPGRADABLE_TAPROOT_VERSION"), (unsigned int)SCRIPT_VERIFY_DISCOURAGE_UPGRADABLE_TAPROOT_VERSION},
74};
75
76unsigned int ParseScriptFlags(std::string strFlags)
77{
78 unsigned int flags = SCRIPT_VERIFY_NONE;
79 if (strFlags.empty() || strFlags == "NONE") return flags;
80
81 std::vector<std::string> words = SplitString(strFlags, ',');
82 for (const std::string& word : words)
83 {
84 if (!mapFlagNames.count(word))
85 BOOST_ERROR("Bad test: unknown verification flag '" << word << "'");
86 flags |= mapFlagNames[word];
87 }
88 return flags;
89}
90
91// Check that all flags in STANDARD_SCRIPT_VERIFY_FLAGS are present in mapFlagNames.
93{
94 unsigned int standard_flags_missing{STANDARD_SCRIPT_VERIFY_FLAGS};
95 for (const auto& pair : mapFlagNames) {
96 standard_flags_missing &= ~(pair.second);
97 }
98 return standard_flags_missing == 0;
99}
100
101std::string FormatScriptFlags(unsigned int flags)
102{
103 if (flags == SCRIPT_VERIFY_NONE) {
104 return "";
105 }
106 std::string ret;
107 std::map<std::string, unsigned int>::const_iterator it = mapFlagNames.begin();
108 while (it != mapFlagNames.end()) {
109 if (flags & it->second) {
110 ret += it->first + ",";
111 }
112 it++;
113 }
114 return ret.substr(0, ret.size() - 1);
115}
116
117/*
118* Check that the input scripts of a transaction are valid/invalid as expected.
119*/
120bool CheckTxScripts(const CTransaction& tx, const std::map<COutPoint, CScript>& map_prevout_scriptPubKeys,
121 const std::map<COutPoint, int64_t>& map_prevout_values, unsigned int flags,
122 const PrecomputedTransactionData& txdata, const std::string& strTest, bool expect_valid)
123{
124 bool tx_valid = true;
126 for (unsigned int i = 0; i < tx.vin.size() && tx_valid; ++i) {
127 const CTxIn input = tx.vin[i];
128 const CAmount amount = map_prevout_values.count(input.prevout) ? map_prevout_values.at(input.prevout) : 0;
129 try {
130 tx_valid = VerifyScript(input.scriptSig, map_prevout_scriptPubKeys.at(input.prevout),
132 } catch (...) {
133 BOOST_ERROR("Bad test: " << strTest);
134 return true; // The test format is bad and an error is thrown. Return true to silence further error.
135 }
136 if (expect_valid) {
137 BOOST_CHECK_MESSAGE(tx_valid, strTest);
138 BOOST_CHECK_MESSAGE((err == SCRIPT_ERR_OK), ScriptErrorString(err));
140 }
141 }
142 if (!expect_valid) {
143 BOOST_CHECK_MESSAGE(!tx_valid, strTest);
144 BOOST_CHECK_MESSAGE((err != SCRIPT_ERR_OK), ScriptErrorString(err));
145 }
146 return (tx_valid == expect_valid);
147}
148
149/*
150 * Trim or fill flags to make the combination valid:
151 * WITNESS must be used with P2SH
152 * CLEANSTACK must be used WITNESS and P2SH
153 */
154
155unsigned int TrimFlags(unsigned int flags)
156{
157 // WITNESS requires P2SH
158 if (!(flags & SCRIPT_VERIFY_P2SH)) flags &= ~(unsigned int)SCRIPT_VERIFY_WITNESS;
159
160 // CLEANSTACK requires WITNESS (and transitively CLEANSTACK requires P2SH)
161 if (!(flags & SCRIPT_VERIFY_WITNESS)) flags &= ~(unsigned int)SCRIPT_VERIFY_CLEANSTACK;
163 return flags;
164}
165
166unsigned int FillFlags(unsigned int flags)
167{
168 // CLEANSTACK implies WITNESS
170
171 // WITNESS implies P2SH (and transitively CLEANSTACK implies P2SH)
174 return flags;
175}
176
177// Exclude each possible script verify flag from flags. Returns a set of these flag combinations
178// that are valid and without duplicates. For example: if flags=1111 and the 4 possible flags are
179// 0001, 0010, 0100, and 1000, this should return the set {0111, 1011, 1101, 1110}.
180// Assumes that mapFlagNames contains all script verify flags.
181std::set<unsigned int> ExcludeIndividualFlags(unsigned int flags)
182{
183 std::set<unsigned int> flags_combos;
184 for (const auto& pair : mapFlagNames) {
185 const unsigned int flags_excluding_one = TrimFlags(flags & ~(pair.second));
186 if (flags != flags_excluding_one) {
187 flags_combos.insert(flags_excluding_one);
188 }
189 }
190 return flags_combos;
191}
192
194
196{
197 BOOST_CHECK_MESSAGE(CheckMapFlagNames(), "mapFlagNames is missing a script verification flag");
198 // Read tests from test/data/tx_valid.json
199 UniValue tests = read_json(json_tests::tx_valid);
200
201 for (unsigned int idx = 0; idx < tests.size(); idx++) {
202 const UniValue& test = tests[idx];
203 std::string strTest = test.write();
204 if (test[0].isArray())
205 {
206 if (test.size() != 3 || !test[1].isStr() || !test[2].isStr())
207 {
208 BOOST_ERROR("Bad test: " << strTest);
209 continue;
210 }
211
212 std::map<COutPoint, CScript> mapprevOutScriptPubKeys;
213 std::map<COutPoint, int64_t> mapprevOutValues;
214 UniValue inputs = test[0].get_array();
215 bool fValid = true;
216 for (unsigned int inpIdx = 0; inpIdx < inputs.size(); inpIdx++) {
217 const UniValue& input = inputs[inpIdx];
218 if (!input.isArray()) {
219 fValid = false;
220 break;
221 }
222 const UniValue& vinput = input.get_array();
223 if (vinput.size() < 3 || vinput.size() > 4)
224 {
225 fValid = false;
226 break;
227 }
228 COutPoint outpoint{Txid::FromHex(vinput[0].get_str()).value(), uint32_t(vinput[1].getInt<int>())};
229 mapprevOutScriptPubKeys[outpoint] = ParseScript(vinput[2].get_str());
230 if (vinput.size() >= 4)
231 {
232 mapprevOutValues[outpoint] = vinput[3].getInt<int64_t>();
233 }
234 }
235 if (!fValid)
236 {
237 BOOST_ERROR("Bad test: " << strTest);
238 continue;
239 }
240
241 std::string transaction = test[1].get_str();
242 DataStream stream(ParseHex(transaction));
244
245 TxValidationState state;
246 BOOST_CHECK_MESSAGE(CheckTransaction(tx, state), strTest);
247 BOOST_CHECK(state.IsValid());
248
250 unsigned int verify_flags = ParseScriptFlags(test[2].get_str());
251
252 // Check that the test gives a valid combination of flags (otherwise VerifyScript will throw). Don't edit the flags.
253 if (~verify_flags != FillFlags(~verify_flags)) {
254 BOOST_ERROR("Bad test flags: " << strTest);
255 }
256
257 BOOST_CHECK_MESSAGE(CheckTxScripts(tx, mapprevOutScriptPubKeys, mapprevOutValues, ~verify_flags, txdata, strTest, /*expect_valid=*/true),
258 "Tx unexpectedly failed: " << strTest);
259
260 // Backwards compatibility of script verification flags: Removing any flag(s) should not invalidate a valid transaction
261 for (const auto& [name, flag] : mapFlagNames) {
262 // Removing individual flags
263 unsigned int flags = TrimFlags(~(verify_flags | flag));
264 if (!CheckTxScripts(tx, mapprevOutScriptPubKeys, mapprevOutValues, flags, txdata, strTest, /*expect_valid=*/true)) {
265 BOOST_ERROR("Tx unexpectedly failed with flag " << name << " unset: " << strTest);
266 }
267 // Removing random combinations of flags
268 flags = TrimFlags(~(verify_flags | (unsigned int)m_rng.randbits(mapFlagNames.size())));
269 if (!CheckTxScripts(tx, mapprevOutScriptPubKeys, mapprevOutValues, flags, txdata, strTest, /*expect_valid=*/true)) {
270 BOOST_ERROR("Tx unexpectedly failed with random flags " << ToString(flags) << ": " << strTest);
271 }
272 }
273
274 // Check that flags are maximal: transaction should fail if any unset flags are set.
275 for (auto flags_excluding_one : ExcludeIndividualFlags(verify_flags)) {
276 if (!CheckTxScripts(tx, mapprevOutScriptPubKeys, mapprevOutValues, ~flags_excluding_one, txdata, strTest, /*expect_valid=*/false)) {
277 BOOST_ERROR("Too many flags unset: " << strTest);
278 }
279 }
280 }
281 }
282}
283
285{
286 // Read tests from test/data/tx_invalid.json
287 UniValue tests = read_json(json_tests::tx_invalid);
288
289 for (unsigned int idx = 0; idx < tests.size(); idx++) {
290 const UniValue& test = tests[idx];
291 std::string strTest = test.write();
292 if (test[0].isArray())
293 {
294 if (test.size() != 3 || !test[1].isStr() || !test[2].isStr())
295 {
296 BOOST_ERROR("Bad test: " << strTest);
297 continue;
298 }
299
300 std::map<COutPoint, CScript> mapprevOutScriptPubKeys;
301 std::map<COutPoint, int64_t> mapprevOutValues;
302 UniValue inputs = test[0].get_array();
303 bool fValid = true;
304 for (unsigned int inpIdx = 0; inpIdx < inputs.size(); inpIdx++) {
305 const UniValue& input = inputs[inpIdx];
306 if (!input.isArray()) {
307 fValid = false;
308 break;
309 }
310 const UniValue& vinput = input.get_array();
311 if (vinput.size() < 3 || vinput.size() > 4)
312 {
313 fValid = false;
314 break;
315 }
316 COutPoint outpoint{Txid::FromHex(vinput[0].get_str()).value(), uint32_t(vinput[1].getInt<int>())};
317 mapprevOutScriptPubKeys[outpoint] = ParseScript(vinput[2].get_str());
318 if (vinput.size() >= 4)
319 {
320 mapprevOutValues[outpoint] = vinput[3].getInt<int64_t>();
321 }
322 }
323 if (!fValid)
324 {
325 BOOST_ERROR("Bad test: " << strTest);
326 continue;
327 }
328
329 std::string transaction = test[1].get_str();
330 DataStream stream(ParseHex(transaction));
332
333 TxValidationState state;
334 if (!CheckTransaction(tx, state) || state.IsInvalid()) {
335 BOOST_CHECK_MESSAGE(test[2].get_str() == "BADTX", strTest);
336 continue;
337 }
338
340 unsigned int verify_flags = ParseScriptFlags(test[2].get_str());
341
342 // Check that the test gives a valid combination of flags (otherwise VerifyScript will throw). Don't edit the flags.
343 if (verify_flags != FillFlags(verify_flags)) {
344 BOOST_ERROR("Bad test flags: " << strTest);
345 }
346
347 // Not using FillFlags() in the main test, in order to detect invalid verifyFlags combination
348 BOOST_CHECK_MESSAGE(CheckTxScripts(tx, mapprevOutScriptPubKeys, mapprevOutValues, verify_flags, txdata, strTest, /*expect_valid=*/false),
349 "Tx unexpectedly passed: " << strTest);
350
351 // Backwards compatibility of script verification flags: Adding any flag(s) should not validate an invalid transaction
352 for (const auto& [name, flag] : mapFlagNames) {
353 unsigned int flags = FillFlags(verify_flags | flag);
354 // Adding individual flags
355 if (!CheckTxScripts(tx, mapprevOutScriptPubKeys, mapprevOutValues, flags, txdata, strTest, /*expect_valid=*/false)) {
356 BOOST_ERROR("Tx unexpectedly passed with flag " << name << " set: " << strTest);
357 }
358 // Adding random combinations of flags
359 flags = FillFlags(verify_flags | (unsigned int)m_rng.randbits(mapFlagNames.size()));
360 if (!CheckTxScripts(tx, mapprevOutScriptPubKeys, mapprevOutValues, flags, txdata, strTest, /*expect_valid=*/false)) {
361 BOOST_ERROR("Tx unexpectedly passed with random flags " << name << ": " << strTest);
362 }
363 }
364
365 // Check that flags are minimal: transaction should succeed if any set flags are unset.
366 for (auto flags_excluding_one : ExcludeIndividualFlags(verify_flags)) {
367 if (!CheckTxScripts(tx, mapprevOutScriptPubKeys, mapprevOutValues, flags_excluding_one, txdata, strTest, /*expect_valid=*/true)) {
368 BOOST_ERROR("Too many flags set: " << strTest);
369 }
370 }
371 }
372 }
373}
374
376{
378
379 TxValidationState state;
380 BOOST_CHECK_MESSAGE(!CheckTransaction(CTransaction(empty), state), "Transaction with no inputs should be invalid.");
381 BOOST_CHECK(state.GetRejectReason() == "bad-txns-vin-empty");
382}
383
385{
386 auto createTransaction =[](size_t payloadSize) {
388 tx.vin.resize(1);
389 tx.vout.emplace_back(1, CScript() << OP_RETURN << std::vector<unsigned char>(payloadSize));
390 return CTransaction(tx);
391 };
392 const auto maxTransactionSize = MAX_BLOCK_WEIGHT / WITNESS_SCALE_FACTOR;
393 const auto oversizedTransactionBaseSize = ::GetSerializeSize(TX_NO_WITNESS(createTransaction(maxTransactionSize))) - maxTransactionSize;
394
395 auto maxPayloadSize = maxTransactionSize - oversizedTransactionBaseSize;
396 {
397 TxValidationState state;
398 CheckTransaction(createTransaction(maxPayloadSize), state);
399 BOOST_CHECK(state.GetRejectReason() != "bad-txns-oversize");
400 }
401
402 maxPayloadSize += 1;
403 {
404 TxValidationState state;
405 BOOST_CHECK_MESSAGE(!CheckTransaction(createTransaction(maxPayloadSize), state), "Oversized transaction should be invalid");
406 BOOST_CHECK(state.GetRejectReason() == "bad-txns-oversize");
407 }
408}
409
410BOOST_AUTO_TEST_CASE(basic_transaction_tests)
411{
412 // Random real transaction (e2769b09e784f32f62ef849763d4f45b98e07ba658647343b915ff832b110436)
413 unsigned char ch[] = {0x01, 0x00, 0x00, 0x00, 0x01, 0x6b, 0xff, 0x7f, 0xcd, 0x4f, 0x85, 0x65, 0xef, 0x40, 0x6d, 0xd5, 0xd6, 0x3d, 0x4f, 0xf9, 0x4f, 0x31, 0x8f, 0xe8, 0x20, 0x27, 0xfd, 0x4d, 0xc4, 0x51, 0xb0, 0x44, 0x74, 0x01, 0x9f, 0x74, 0xb4, 0x00, 0x00, 0x00, 0x00, 0x8c, 0x49, 0x30, 0x46, 0x02, 0x21, 0x00, 0xda, 0x0d, 0xc6, 0xae, 0xce, 0xfe, 0x1e, 0x06, 0xef, 0xdf, 0x05, 0x77, 0x37, 0x57, 0xde, 0xb1, 0x68, 0x82, 0x09, 0x30, 0xe3, 0xb0, 0xd0, 0x3f, 0x46, 0xf5, 0xfc, 0xf1, 0x50, 0xbf, 0x99, 0x0c, 0x02, 0x21, 0x00, 0xd2, 0x5b, 0x5c, 0x87, 0x04, 0x00, 0x76, 0xe4, 0xf2, 0x53, 0xf8, 0x26, 0x2e, 0x76, 0x3e, 0x2d, 0xd5, 0x1e, 0x7f, 0xf0, 0xbe, 0x15, 0x77, 0x27, 0xc4, 0xbc, 0x42, 0x80, 0x7f, 0x17, 0xbd, 0x39, 0x01, 0x41, 0x04, 0xe6, 0xc2, 0x6e, 0xf6, 0x7d, 0xc6, 0x10, 0xd2, 0xcd, 0x19, 0x24, 0x84, 0x78, 0x9a, 0x6c, 0xf9, 0xae, 0xa9, 0x93, 0x0b, 0x94, 0x4b, 0x7e, 0x2d, 0xb5, 0x34, 0x2b, 0x9d, 0x9e, 0x5b, 0x9f, 0xf7, 0x9a, 0xff, 0x9a, 0x2e, 0xe1, 0x97, 0x8d, 0xd7, 0xfd, 0x01, 0xdf, 0xc5, 0x22, 0xee, 0x02, 0x28, 0x3d, 0x3b, 0x06, 0xa9, 0xd0, 0x3a, 0xcf, 0x80, 0x96, 0x96, 0x8d, 0x7d, 0xbb, 0x0f, 0x91, 0x78, 0xff, 0xff, 0xff, 0xff, 0x02, 0x8b, 0xa7, 0x94, 0x0e, 0x00, 0x00, 0x00, 0x00, 0x19, 0x76, 0xa9, 0x14, 0xba, 0xde, 0xec, 0xfd, 0xef, 0x05, 0x07, 0x24, 0x7f, 0xc8, 0xf7, 0x42, 0x41, 0xd7, 0x3b, 0xc0, 0x39, 0x97, 0x2d, 0x7b, 0x88, 0xac, 0x40, 0x94, 0xa8, 0x02, 0x00, 0x00, 0x00, 0x00, 0x19, 0x76, 0xa9, 0x14, 0xc1, 0x09, 0x32, 0x48, 0x3f, 0xec, 0x93, 0xed, 0x51, 0xf5, 0xfe, 0x95, 0xe7, 0x25, 0x59, 0xf2, 0xcc, 0x70, 0x43, 0xf9, 0x88, 0xac, 0x00, 0x00, 0x00, 0x00, 0x00};
414 std::vector<unsigned char> vch(ch, ch + sizeof(ch) -1);
415 DataStream stream(vch);
417 stream >> TX_WITH_WITNESS(tx);
418 TxValidationState state;
419 BOOST_CHECK_MESSAGE(CheckTransaction(CTransaction(tx), state) && state.IsValid(), "Simple deserialized transaction should be valid.");
420
421 // Check that duplicate txins fail
422 tx.vin.push_back(tx.vin[0]);
423 BOOST_CHECK_MESSAGE(!CheckTransaction(CTransaction(tx), state) || !state.IsValid(), "Transaction with duplicate txins should be invalid.");
424}
425
427{
429 CCoinsView coinsDummy;
430 CCoinsViewCache coins(&coinsDummy);
431 std::vector<CMutableTransaction> dummyTransactions =
432 SetupDummyInputs(keystore, coins, {11*CENT, 50*CENT, 21*CENT, 22*CENT});
433
435 t1.vin.resize(3);
436 t1.vin[0].prevout.hash = dummyTransactions[0].GetHash();
437 t1.vin[0].prevout.n = 1;
438 t1.vin[0].scriptSig << std::vector<unsigned char>(65, 0);
439 t1.vin[1].prevout.hash = dummyTransactions[1].GetHash();
440 t1.vin[1].prevout.n = 0;
441 t1.vin[1].scriptSig << std::vector<unsigned char>(65, 0) << std::vector<unsigned char>(33, 4);
442 t1.vin[2].prevout.hash = dummyTransactions[1].GetHash();
443 t1.vin[2].prevout.n = 1;
444 t1.vin[2].scriptSig << std::vector<unsigned char>(65, 0) << std::vector<unsigned char>(33, 4);
445 t1.vout.resize(2);
446 t1.vout[0].nValue = 90*CENT;
447 t1.vout[0].scriptPubKey << OP_1;
448
450}
451
452static void CreateCreditAndSpend(const FillableSigningProvider& keystore, const CScript& outscript, CTransactionRef& output, CMutableTransaction& input, bool success = true)
453{
454 CMutableTransaction outputm;
455 outputm.version = 1;
456 outputm.vin.resize(1);
457 outputm.vin[0].prevout.SetNull();
458 outputm.vin[0].scriptSig = CScript();
459 outputm.vout.resize(1);
460 outputm.vout[0].nValue = 1;
461 outputm.vout[0].scriptPubKey = outscript;
462 DataStream ssout;
463 ssout << TX_WITH_WITNESS(outputm);
464 ssout >> TX_WITH_WITNESS(output);
465 assert(output->vin.size() == 1);
466 assert(output->vin[0] == outputm.vin[0]);
467 assert(output->vout.size() == 1);
468 assert(output->vout[0] == outputm.vout[0]);
469
470 CMutableTransaction inputm;
471 inputm.version = 1;
472 inputm.vin.resize(1);
473 inputm.vin[0].prevout.hash = output->GetHash();
474 inputm.vin[0].prevout.n = 0;
475 inputm.vout.resize(1);
476 inputm.vout[0].nValue = 1;
477 inputm.vout[0].scriptPubKey = CScript();
478 SignatureData empty;
479 bool ret = SignSignature(keystore, *output, inputm, 0, SIGHASH_ALL, empty);
480 assert(ret == success);
481 DataStream ssin;
482 ssin << TX_WITH_WITNESS(inputm);
483 ssin >> TX_WITH_WITNESS(input);
484 assert(input.vin.size() == 1);
485 assert(input.vin[0] == inputm.vin[0]);
486 assert(input.vout.size() == 1);
487 assert(input.vout[0] == inputm.vout[0]);
488 assert(input.vin[0].scriptWitness.stack == inputm.vin[0].scriptWitness.stack);
489}
490
491static void CheckWithFlag(const CTransactionRef& output, const CMutableTransaction& input, uint32_t flags, bool success)
492{
493 ScriptError error;
494 CTransaction inputi(input);
495 bool ret = VerifyScript(inputi.vin[0].scriptSig, output->vout[0].scriptPubKey, &inputi.vin[0].scriptWitness, flags, TransactionSignatureChecker(&inputi, 0, output->vout[0].nValue, MissingDataBehavior::ASSERT_FAIL), &error);
496 assert(ret == success);
497}
498
499static CScript PushAll(const std::vector<valtype>& values)
500{
501 CScript result;
502 for (const valtype& v : values) {
503 if (v.size() == 0) {
504 result << OP_0;
505 } else if (v.size() == 1 && v[0] >= 1 && v[0] <= 16) {
506 result << CScript::EncodeOP_N(v[0]);
507 } else if (v.size() == 1 && v[0] == 0x81) {
508 result << OP_1NEGATE;
509 } else {
510 result << v;
511 }
512 }
513 return result;
514}
515
516static void ReplaceRedeemScript(CScript& script, const CScript& redeemScript)
517{
518 std::vector<valtype> stack;
520 assert(stack.size() > 0);
521 stack.back() = std::vector<unsigned char>(redeemScript.begin(), redeemScript.end());
522 script = PushAll(stack);
523}
524
525BOOST_AUTO_TEST_CASE(test_big_witness_transaction)
526{
528 mtx.version = 1;
529
530 CKey key = GenerateRandomKey(); // Need to use compressed keys in segwit or the signing will fail
532 BOOST_CHECK(keystore.AddKeyPubKey(key, key.GetPubKey()));
533 CKeyID hash = key.GetPubKey().GetID();
534 CScript scriptPubKey = CScript() << OP_0 << std::vector<unsigned char>(hash.begin(), hash.end());
535
536 std::vector<int> sigHashes;
537 sigHashes.push_back(SIGHASH_NONE | SIGHASH_ANYONECANPAY);
538 sigHashes.push_back(SIGHASH_SINGLE | SIGHASH_ANYONECANPAY);
539 sigHashes.push_back(SIGHASH_ALL | SIGHASH_ANYONECANPAY);
540 sigHashes.push_back(SIGHASH_NONE);
541 sigHashes.push_back(SIGHASH_SINGLE);
542 sigHashes.push_back(SIGHASH_ALL);
543
544 // create a big transaction of 4500 inputs signed by the same key
545 for(uint32_t ij = 0; ij < 4500; ij++) {
546 uint32_t i = mtx.vin.size();
547 COutPoint outpoint(Txid::FromHex("0000000000000000000000000000000000000000000000000000000000000100").value(), i);
548
549 mtx.vin.resize(mtx.vin.size() + 1);
550 mtx.vin[i].prevout = outpoint;
551 mtx.vin[i].scriptSig = CScript();
552
553 mtx.vout.resize(mtx.vout.size() + 1);
554 mtx.vout[i].nValue = 1000;
555 mtx.vout[i].scriptPubKey = CScript() << OP_1;
556 }
557
558 // sign all inputs
559 for(uint32_t i = 0; i < mtx.vin.size(); i++) {
560 SignatureData empty;
561 bool hashSigned = SignSignature(keystore, scriptPubKey, mtx, i, 1000, sigHashes.at(i % sigHashes.size()), empty);
562 assert(hashSigned);
563 }
564
565 DataStream ssout;
566 ssout << TX_WITH_WITNESS(mtx);
568
569 // check all inputs concurrently, with the cache
571 CCheckQueue<CScriptCheck> scriptcheckqueue(/*batch_size=*/128, /*worker_threads_num=*/20);
572 CCheckQueueControl<CScriptCheck> control(scriptcheckqueue);
573
574 std::vector<Coin> coins;
575 for(uint32_t i = 0; i < mtx.vin.size(); i++) {
576 Coin coin;
577 coin.nHeight = 1;
578 coin.fCoinBase = false;
579 coin.out.nValue = 1000;
580 coin.out.scriptPubKey = scriptPubKey;
581 coins.emplace_back(std::move(coin));
582 }
583
585
586 for(uint32_t i = 0; i < mtx.vin.size(); i++) {
587 std::vector<CScriptCheck> vChecks;
588 vChecks.emplace_back(coins[tx.vin[i].prevout.n].out, tx, signature_cache, i, SCRIPT_VERIFY_P2SH | SCRIPT_VERIFY_WITNESS, false, &txdata);
589 control.Add(std::move(vChecks));
590 }
591
592 bool controlCheck = !control.Complete().has_value();
593 assert(controlCheck);
594}
595
597{
598 SignatureData sigdata;
599 sigdata = DataFromTransaction(input1, 0, tx->vout[0]);
600 sigdata.MergeSignatureData(DataFromTransaction(input2, 0, tx->vout[0]));
601 ProduceSignature(DUMMY_SIGNING_PROVIDER, MutableTransactionSignatureCreator(input1, 0, tx->vout[0].nValue, SIGHASH_ALL), tx->vout[0].scriptPubKey, sigdata);
602 return sigdata;
603}
604
606{
607 FillableSigningProvider keystore, keystore2;
608 CKey key1 = GenerateRandomKey();
609 CKey key2 = GenerateRandomKey();
610 CKey key3 = GenerateRandomKey();
611 CKey key1L = GenerateRandomKey(/*compressed=*/false);
612 CKey key2L = GenerateRandomKey(/*compressed=*/false);
613 CPubKey pubkey1 = key1.GetPubKey();
614 CPubKey pubkey2 = key2.GetPubKey();
615 CPubKey pubkey3 = key3.GetPubKey();
616 CPubKey pubkey1L = key1L.GetPubKey();
617 CPubKey pubkey2L = key2L.GetPubKey();
618 BOOST_CHECK(keystore.AddKeyPubKey(key1, pubkey1));
619 BOOST_CHECK(keystore.AddKeyPubKey(key2, pubkey2));
620 BOOST_CHECK(keystore.AddKeyPubKey(key1L, pubkey1L));
621 BOOST_CHECK(keystore.AddKeyPubKey(key2L, pubkey2L));
622 CScript scriptPubkey1, scriptPubkey2, scriptPubkey1L, scriptPubkey2L, scriptMulti;
623 scriptPubkey1 << ToByteVector(pubkey1) << OP_CHECKSIG;
624 scriptPubkey2 << ToByteVector(pubkey2) << OP_CHECKSIG;
625 scriptPubkey1L << ToByteVector(pubkey1L) << OP_CHECKSIG;
626 scriptPubkey2L << ToByteVector(pubkey2L) << OP_CHECKSIG;
627 std::vector<CPubKey> oneandthree;
628 oneandthree.push_back(pubkey1);
629 oneandthree.push_back(pubkey3);
630 scriptMulti = GetScriptForMultisig(2, oneandthree);
631 BOOST_CHECK(keystore.AddCScript(scriptPubkey1));
632 BOOST_CHECK(keystore.AddCScript(scriptPubkey2));
633 BOOST_CHECK(keystore.AddCScript(scriptPubkey1L));
634 BOOST_CHECK(keystore.AddCScript(scriptPubkey2L));
635 BOOST_CHECK(keystore.AddCScript(scriptMulti));
636 CScript destination_script_1, destination_script_2, destination_script_1L, destination_script_2L, destination_script_multi;
637 destination_script_1 = GetScriptForDestination(WitnessV0KeyHash(pubkey1));
638 destination_script_2 = GetScriptForDestination(WitnessV0KeyHash(pubkey2));
639 destination_script_1L = GetScriptForDestination(WitnessV0KeyHash(pubkey1L));
640 destination_script_2L = GetScriptForDestination(WitnessV0KeyHash(pubkey2L));
641 destination_script_multi = GetScriptForDestination(WitnessV0ScriptHash(scriptMulti));
642 BOOST_CHECK(keystore.AddCScript(destination_script_1));
643 BOOST_CHECK(keystore.AddCScript(destination_script_2));
644 BOOST_CHECK(keystore.AddCScript(destination_script_1L));
645 BOOST_CHECK(keystore.AddCScript(destination_script_2L));
646 BOOST_CHECK(keystore.AddCScript(destination_script_multi));
647 BOOST_CHECK(keystore2.AddCScript(scriptMulti));
648 BOOST_CHECK(keystore2.AddCScript(destination_script_multi));
649 BOOST_CHECK(keystore2.AddKeyPubKey(key3, pubkey3));
650
651 CTransactionRef output1, output2;
652 CMutableTransaction input1, input2;
653
654 // Normal pay-to-compressed-pubkey.
655 CreateCreditAndSpend(keystore, scriptPubkey1, output1, input1);
656 CreateCreditAndSpend(keystore, scriptPubkey2, output2, input2);
657 CheckWithFlag(output1, input1, SCRIPT_VERIFY_NONE, true);
658 CheckWithFlag(output1, input1, SCRIPT_VERIFY_P2SH, true);
660 CheckWithFlag(output1, input1, STANDARD_SCRIPT_VERIFY_FLAGS, true);
661 CheckWithFlag(output1, input2, SCRIPT_VERIFY_NONE, false);
662 CheckWithFlag(output1, input2, SCRIPT_VERIFY_P2SH, false);
663 CheckWithFlag(output1, input2, SCRIPT_VERIFY_WITNESS | SCRIPT_VERIFY_P2SH, false);
664 CheckWithFlag(output1, input2, STANDARD_SCRIPT_VERIFY_FLAGS, false);
665
666 // P2SH pay-to-compressed-pubkey.
667 CreateCreditAndSpend(keystore, GetScriptForDestination(ScriptHash(scriptPubkey1)), output1, input1);
668 CreateCreditAndSpend(keystore, GetScriptForDestination(ScriptHash(scriptPubkey2)), output2, input2);
669 ReplaceRedeemScript(input2.vin[0].scriptSig, scriptPubkey1);
670 CheckWithFlag(output1, input1, SCRIPT_VERIFY_NONE, true);
671 CheckWithFlag(output1, input1, SCRIPT_VERIFY_P2SH, true);
673 CheckWithFlag(output1, input1, STANDARD_SCRIPT_VERIFY_FLAGS, true);
674 CheckWithFlag(output1, input2, SCRIPT_VERIFY_NONE, true);
675 CheckWithFlag(output1, input2, SCRIPT_VERIFY_P2SH, false);
676 CheckWithFlag(output1, input2, SCRIPT_VERIFY_WITNESS | SCRIPT_VERIFY_P2SH, false);
677 CheckWithFlag(output1, input2, STANDARD_SCRIPT_VERIFY_FLAGS, false);
678
679 // Witness pay-to-compressed-pubkey (v0).
680 CreateCreditAndSpend(keystore, destination_script_1, output1, input1);
681 CreateCreditAndSpend(keystore, destination_script_2, output2, input2);
682 CheckWithFlag(output1, input1, SCRIPT_VERIFY_NONE, true);
683 CheckWithFlag(output1, input1, SCRIPT_VERIFY_P2SH, true);
685 CheckWithFlag(output1, input1, STANDARD_SCRIPT_VERIFY_FLAGS, true);
686 CheckWithFlag(output1, input2, SCRIPT_VERIFY_NONE, true);
687 CheckWithFlag(output1, input2, SCRIPT_VERIFY_P2SH, true);
688 CheckWithFlag(output1, input2, SCRIPT_VERIFY_WITNESS | SCRIPT_VERIFY_P2SH, false);
689 CheckWithFlag(output1, input2, STANDARD_SCRIPT_VERIFY_FLAGS, false);
690
691 // P2SH witness pay-to-compressed-pubkey (v0).
692 CreateCreditAndSpend(keystore, GetScriptForDestination(ScriptHash(destination_script_1)), output1, input1);
693 CreateCreditAndSpend(keystore, GetScriptForDestination(ScriptHash(destination_script_2)), output2, input2);
694 ReplaceRedeemScript(input2.vin[0].scriptSig, destination_script_1);
695 CheckWithFlag(output1, input1, SCRIPT_VERIFY_NONE, true);
696 CheckWithFlag(output1, input1, SCRIPT_VERIFY_P2SH, true);
698 CheckWithFlag(output1, input1, STANDARD_SCRIPT_VERIFY_FLAGS, true);
699 CheckWithFlag(output1, input2, SCRIPT_VERIFY_NONE, true);
700 CheckWithFlag(output1, input2, SCRIPT_VERIFY_P2SH, true);
701 CheckWithFlag(output1, input2, SCRIPT_VERIFY_WITNESS | SCRIPT_VERIFY_P2SH, false);
702 CheckWithFlag(output1, input2, STANDARD_SCRIPT_VERIFY_FLAGS, false);
703
704 // Normal pay-to-uncompressed-pubkey.
705 CreateCreditAndSpend(keystore, scriptPubkey1L, output1, input1);
706 CreateCreditAndSpend(keystore, scriptPubkey2L, output2, input2);
707 CheckWithFlag(output1, input1, SCRIPT_VERIFY_NONE, true);
708 CheckWithFlag(output1, input1, SCRIPT_VERIFY_P2SH, true);
710 CheckWithFlag(output1, input1, STANDARD_SCRIPT_VERIFY_FLAGS, true);
711 CheckWithFlag(output1, input2, SCRIPT_VERIFY_NONE, false);
712 CheckWithFlag(output1, input2, SCRIPT_VERIFY_P2SH, false);
713 CheckWithFlag(output1, input2, SCRIPT_VERIFY_WITNESS | SCRIPT_VERIFY_P2SH, false);
714 CheckWithFlag(output1, input2, STANDARD_SCRIPT_VERIFY_FLAGS, false);
715
716 // P2SH pay-to-uncompressed-pubkey.
717 CreateCreditAndSpend(keystore, GetScriptForDestination(ScriptHash(scriptPubkey1L)), output1, input1);
718 CreateCreditAndSpend(keystore, GetScriptForDestination(ScriptHash(scriptPubkey2L)), output2, input2);
719 ReplaceRedeemScript(input2.vin[0].scriptSig, scriptPubkey1L);
720 CheckWithFlag(output1, input1, SCRIPT_VERIFY_NONE, true);
721 CheckWithFlag(output1, input1, SCRIPT_VERIFY_P2SH, true);
723 CheckWithFlag(output1, input1, STANDARD_SCRIPT_VERIFY_FLAGS, true);
724 CheckWithFlag(output1, input2, SCRIPT_VERIFY_NONE, true);
725 CheckWithFlag(output1, input2, SCRIPT_VERIFY_P2SH, false);
726 CheckWithFlag(output1, input2, SCRIPT_VERIFY_WITNESS | SCRIPT_VERIFY_P2SH, false);
727 CheckWithFlag(output1, input2, STANDARD_SCRIPT_VERIFY_FLAGS, false);
728
729 // Signing disabled for witness pay-to-uncompressed-pubkey (v1).
730 CreateCreditAndSpend(keystore, destination_script_1L, output1, input1, false);
731 CreateCreditAndSpend(keystore, destination_script_2L, output2, input2, false);
732
733 // Signing disabled for P2SH witness pay-to-uncompressed-pubkey (v1).
734 CreateCreditAndSpend(keystore, GetScriptForDestination(ScriptHash(destination_script_1L)), output1, input1, false);
735 CreateCreditAndSpend(keystore, GetScriptForDestination(ScriptHash(destination_script_2L)), output2, input2, false);
736
737 // Normal 2-of-2 multisig
738 CreateCreditAndSpend(keystore, scriptMulti, output1, input1, false);
739 CheckWithFlag(output1, input1, SCRIPT_VERIFY_NONE, false);
740 CreateCreditAndSpend(keystore2, scriptMulti, output2, input2, false);
741 CheckWithFlag(output2, input2, SCRIPT_VERIFY_NONE, false);
742 BOOST_CHECK(*output1 == *output2);
743 UpdateInput(input1.vin[0], CombineSignatures(input1, input2, output1));
744 CheckWithFlag(output1, input1, STANDARD_SCRIPT_VERIFY_FLAGS, true);
745
746 // P2SH 2-of-2 multisig
747 CreateCreditAndSpend(keystore, GetScriptForDestination(ScriptHash(scriptMulti)), output1, input1, false);
748 CheckWithFlag(output1, input1, SCRIPT_VERIFY_NONE, true);
749 CheckWithFlag(output1, input1, SCRIPT_VERIFY_P2SH, false);
750 CreateCreditAndSpend(keystore2, GetScriptForDestination(ScriptHash(scriptMulti)), output2, input2, false);
751 CheckWithFlag(output2, input2, SCRIPT_VERIFY_NONE, true);
752 CheckWithFlag(output2, input2, SCRIPT_VERIFY_P2SH, false);
753 BOOST_CHECK(*output1 == *output2);
754 UpdateInput(input1.vin[0], CombineSignatures(input1, input2, output1));
755 CheckWithFlag(output1, input1, SCRIPT_VERIFY_P2SH, true);
756 CheckWithFlag(output1, input1, STANDARD_SCRIPT_VERIFY_FLAGS, true);
757
758 // Witness 2-of-2 multisig
759 CreateCreditAndSpend(keystore, destination_script_multi, output1, input1, false);
760 CheckWithFlag(output1, input1, SCRIPT_VERIFY_NONE, true);
761 CheckWithFlag(output1, input1, SCRIPT_VERIFY_P2SH | SCRIPT_VERIFY_WITNESS, false);
762 CreateCreditAndSpend(keystore2, destination_script_multi, output2, input2, false);
763 CheckWithFlag(output2, input2, SCRIPT_VERIFY_NONE, true);
764 CheckWithFlag(output2, input2, SCRIPT_VERIFY_P2SH | SCRIPT_VERIFY_WITNESS, false);
765 BOOST_CHECK(*output1 == *output2);
766 UpdateInput(input1.vin[0], CombineSignatures(input1, input2, output1));
768 CheckWithFlag(output1, input1, STANDARD_SCRIPT_VERIFY_FLAGS, true);
769
770 // P2SH witness 2-of-2 multisig
771 CreateCreditAndSpend(keystore, GetScriptForDestination(ScriptHash(destination_script_multi)), output1, input1, false);
772 CheckWithFlag(output1, input1, SCRIPT_VERIFY_P2SH, true);
773 CheckWithFlag(output1, input1, SCRIPT_VERIFY_P2SH | SCRIPT_VERIFY_WITNESS, false);
774 CreateCreditAndSpend(keystore2, GetScriptForDestination(ScriptHash(destination_script_multi)), output2, input2, false);
775 CheckWithFlag(output2, input2, SCRIPT_VERIFY_P2SH, true);
776 CheckWithFlag(output2, input2, SCRIPT_VERIFY_P2SH | SCRIPT_VERIFY_WITNESS, false);
777 BOOST_CHECK(*output1 == *output2);
778 UpdateInput(input1.vin[0], CombineSignatures(input1, input2, output1));
780 CheckWithFlag(output1, input1, STANDARD_SCRIPT_VERIFY_FLAGS, true);
781}
782
783BOOST_AUTO_TEST_CASE(test_IsStandard)
784{
786 CCoinsView coinsDummy;
787 CCoinsViewCache coins(&coinsDummy);
788 std::vector<CMutableTransaction> dummyTransactions =
789 SetupDummyInputs(keystore, coins, {11*CENT, 50*CENT, 21*CENT, 22*CENT});
790
792 t.vin.resize(1);
793 t.vin[0].prevout.hash = dummyTransactions[0].GetHash();
794 t.vin[0].prevout.n = 1;
795 t.vin[0].scriptSig << std::vector<unsigned char>(65, 0);
796 t.vout.resize(1);
797 t.vout[0].nValue = 90*CENT;
798 CKey key = GenerateRandomKey();
799 t.vout[0].scriptPubKey = GetScriptForDestination(PKHash(key.GetPubKey()));
800
801 constexpr auto CheckIsStandard = [](const auto& t, const unsigned int max_op_return_relay = MAX_OP_RETURN_RELAY) {
802 std::string reason;
803 BOOST_CHECK(IsStandardTx(CTransaction{t}, max_op_return_relay, g_bare_multi, g_dust, reason));
804 BOOST_CHECK(reason.empty());
805 };
806 constexpr auto CheckIsNotStandard = [](const auto& t, const std::string& reason_in, const unsigned int max_op_return_relay = MAX_OP_RETURN_RELAY) {
807 std::string reason;
808 BOOST_CHECK(!IsStandardTx(CTransaction{t}, max_op_return_relay, g_bare_multi, g_dust, reason));
809 BOOST_CHECK_EQUAL(reason_in, reason);
810 };
811
812 CheckIsStandard(t);
813
814 // Check dust with default relay fee:
815 CAmount nDustThreshold = 182 * g_dust.GetFeePerK() / 1000;
816 BOOST_CHECK_EQUAL(nDustThreshold, 546);
817
818 // Add dust outputs up to allowed maximum, still standard!
819 for (size_t i{0}; i < MAX_DUST_OUTPUTS_PER_TX; ++i) {
820 t.vout.emplace_back(0, t.vout[0].scriptPubKey);
821 CheckIsStandard(t);
822 }
823
824 // dust:
825 t.vout[0].nValue = nDustThreshold - 1;
826 CheckIsNotStandard(t, "dust");
827 // not dust:
828 t.vout[0].nValue = nDustThreshold;
829 CheckIsStandard(t);
830
831 // Disallowed version
832 t.version = std::numeric_limits<uint32_t>::max();
833 CheckIsNotStandard(t, "version");
834
835 t.version = 0;
836 CheckIsNotStandard(t, "version");
837
838 t.version = TX_MAX_STANDARD_VERSION + 1;
839 CheckIsNotStandard(t, "version");
840
841 // Allowed version
842 t.version = 1;
843 CheckIsStandard(t);
844
845 t.version = 2;
846 CheckIsStandard(t);
847
848 // Check dust with odd relay fee to verify rounding:
849 // nDustThreshold = 182 * 3702 / 1000
850 g_dust = CFeeRate(3702);
851 // dust:
852 t.vout[0].nValue = 674 - 1;
853 CheckIsNotStandard(t, "dust");
854 // not dust:
855 t.vout[0].nValue = 674;
856 CheckIsStandard(t);
858
859 t.vout[0].scriptPubKey = CScript() << OP_1;
860 CheckIsNotStandard(t, "scriptpubkey");
861
862 // Custom 83-byte TxoutType::NULL_DATA (standard with max_op_return_relay of 83)
863 t.vout[0].scriptPubKey = CScript() << OP_RETURN << "04678afdb0fe5548271967f1a67130b7105cd6a828e03909a67962e0ea1f61deb649f6bc3f4cef3804678afdb0fe5548271967f1a67130b7105cd6a828e03909a67962e0ea1f61deb649f6bc3f4cef38"_hex;
864 BOOST_CHECK_EQUAL(83, t.vout[0].scriptPubKey.size());
865 CheckIsStandard(t, /*max_op_return_relay=*/83);
866
867 // Non-standard if max_op_return_relay datacarrier arg is one less
868 CheckIsNotStandard(t, "datacarrier", /*max_op_return_relay=*/82);
869
870 // Data payload can be encoded in any way...
871 t.vout[0].scriptPubKey = CScript() << OP_RETURN << ""_hex;
872 CheckIsStandard(t);
873 t.vout[0].scriptPubKey = CScript() << OP_RETURN << "00"_hex << "01"_hex;
874 CheckIsStandard(t);
875 // OP_RESERVED *is* considered to be a PUSHDATA type opcode by IsPushOnly()!
876 t.vout[0].scriptPubKey = CScript() << OP_RETURN << OP_RESERVED << -1 << 0 << "01"_hex << 2 << 3 << 4 << 5 << 6 << 7 << 8 << 9 << 10 << 11 << 12 << 13 << 14 << 15 << 16;
877 CheckIsStandard(t);
878 t.vout[0].scriptPubKey = CScript() << OP_RETURN << 0 << "01"_hex << 2 << "ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff"_hex;
879 CheckIsStandard(t);
880
881 // ...so long as it only contains PUSHDATA's
882 t.vout[0].scriptPubKey = CScript() << OP_RETURN << OP_RETURN;
883 CheckIsNotStandard(t, "scriptpubkey");
884
885 // TxoutType::NULL_DATA w/o PUSHDATA
886 t.vout.resize(1);
887 t.vout[0].scriptPubKey = CScript() << OP_RETURN;
888 CheckIsStandard(t);
889
890 // Multiple TxoutType::NULL_DATA are permitted
891 t.vout.resize(2);
892 t.vout[0].scriptPubKey = CScript() << OP_RETURN << "04678afdb0fe5548271967f1a67130b7105cd6a828e03909a67962e0ea1f61deb649f6bc3f4cef38"_hex;
893 t.vout[0].nValue = 0;
894 t.vout[1].scriptPubKey = CScript() << OP_RETURN << "04678afdb0fe5548271967f1a67130b7105cd6a828e03909a67962e0ea1f61deb649f6bc3f4cef38"_hex;
895 t.vout[1].nValue = 0;
896 CheckIsStandard(t);
897
898 t.vout[0].scriptPubKey = CScript() << OP_RETURN << "04678afdb0fe5548271967f1a67130b7105cd6a828e03909a67962e0ea1f61deb649f6bc3f4cef38"_hex;
899 t.vout[1].scriptPubKey = CScript() << OP_RETURN;
900 CheckIsStandard(t);
901
902 t.vout[0].scriptPubKey = CScript() << OP_RETURN;
903 t.vout[1].scriptPubKey = CScript() << OP_RETURN;
904 CheckIsStandard(t);
905
906 t.vout[0].scriptPubKey = CScript() << OP_RETURN << "04678afdb0fe5548271967f1a67130b7105cd6a828e03909a67962e0ea1f61deb649f6bc3f4cef3804678afdb0fe5548271967f1a67130b7105cd6a828e03909a67962e0ea1f61deb649f6bc3f4cef38"_hex;
907 t.vout[1].scriptPubKey = CScript() << OP_RETURN << "04678afdb0fe5548271967f1a67130b7105cd6a828e03909a67962e0ea1f61deb649f6bc3f4cef3804678afdb0fe5548271967f1a67130b7105cd6a828e03909a67962e0ea1f61deb649f6bc3f4cef38"_hex;
908 const auto datacarrier_size = t.vout[0].scriptPubKey.size() + t.vout[1].scriptPubKey.size();
909 CheckIsStandard(t); // Default max relay should never trigger
910 CheckIsStandard(t, /*max_op_return_relay=*/datacarrier_size);
911 CheckIsNotStandard(t, "datacarrier", /*max_op_return_relay=*/datacarrier_size-1);
912
913 // Check large scriptSig (non-standard if size is >1650 bytes)
914 t.vout.resize(1);
915 t.vout[0].nValue = MAX_MONEY;
916 t.vout[0].scriptPubKey = GetScriptForDestination(PKHash(key.GetPubKey()));
917 // OP_PUSHDATA2 with len (3 bytes) + data (1647 bytes) = 1650 bytes
918 t.vin[0].scriptSig = CScript() << std::vector<unsigned char>(1647, 0); // 1650
919 CheckIsStandard(t);
920
921 t.vin[0].scriptSig = CScript() << std::vector<unsigned char>(1648, 0); // 1651
922 CheckIsNotStandard(t, "scriptsig-size");
923
924 // Check scriptSig format (non-standard if there are any other ops than just PUSHs)
925 t.vin[0].scriptSig = CScript()
926 << OP_TRUE << OP_0 << OP_1NEGATE << OP_16 // OP_n (single byte pushes: n = 1, 0, -1, 16)
927 << std::vector<unsigned char>(75, 0) // OP_PUSHx [...x bytes...]
928 << std::vector<unsigned char>(235, 0) // OP_PUSHDATA1 x [...x bytes...]
929 << std::vector<unsigned char>(1234, 0) // OP_PUSHDATA2 x [...x bytes...]
930 << OP_9;
931 CheckIsStandard(t);
932
933 const std::vector<unsigned char> non_push_ops = { // arbitrary set of non-push operations
936
937 CScript::const_iterator pc = t.vin[0].scriptSig.begin();
938 while (pc < t.vin[0].scriptSig.end()) {
939 opcodetype opcode;
940 CScript::const_iterator prev_pc = pc;
941 t.vin[0].scriptSig.GetOp(pc, opcode); // advance to next op
942 // for the sake of simplicity, we only replace single-byte push operations
943 if (opcode >= 1 && opcode <= OP_PUSHDATA4)
944 continue;
945
946 int index = prev_pc - t.vin[0].scriptSig.begin();
947 unsigned char orig_op = *prev_pc; // save op
948 // replace current push-op with each non-push-op
949 for (auto op : non_push_ops) {
950 t.vin[0].scriptSig[index] = op;
951 CheckIsNotStandard(t, "scriptsig-not-pushonly");
952 }
953 t.vin[0].scriptSig[index] = orig_op; // restore op
954 CheckIsStandard(t);
955 }
956
957 // Check tx-size (non-standard if transaction weight is > MAX_STANDARD_TX_WEIGHT)
958 t.vin.clear();
959 t.vin.resize(2438); // size per input (empty scriptSig): 41 bytes
960 t.vout[0].scriptPubKey = CScript() << OP_RETURN << std::vector<unsigned char>(19, 0); // output size: 30 bytes
961 // tx header: 12 bytes => 48 weight units
962 // 2438 inputs: 2438*41 = 99958 bytes => 399832 weight units
963 // 1 output: 30 bytes => 120 weight units
964 // ======================================
965 // total: 400000 weight units
967 CheckIsStandard(t);
968
969 // increase output size by one byte, so we end up with 400004 weight units
970 t.vout[0].scriptPubKey = CScript() << OP_RETURN << std::vector<unsigned char>(20, 0); // output size: 31 bytes
972 CheckIsNotStandard(t, "tx-size");
973
974 // Check bare multisig (standard if policy flag g_bare_multi is set)
975 g_bare_multi = true;
976 t.vout[0].scriptPubKey = GetScriptForMultisig(1, {key.GetPubKey()}); // simple 1-of-1
977 t.vin.resize(1);
978 t.vin[0].scriptSig = CScript() << std::vector<unsigned char>(65, 0);
979 CheckIsStandard(t);
980
981 g_bare_multi = false;
982 CheckIsNotStandard(t, "bare-multisig");
984
985 // Add dust outputs up to allowed maximum
986 assert(t.vout.size() == 1);
987 t.vout.insert(t.vout.end(), MAX_DUST_OUTPUTS_PER_TX, {0, t.vout[0].scriptPubKey});
988
989 // Check compressed P2PK outputs dust threshold (must have leading 02 or 03)
990 t.vout[0].scriptPubKey = CScript() << std::vector<unsigned char>(33, 0x02) << OP_CHECKSIG;
991 t.vout[0].nValue = 576;
992 CheckIsStandard(t);
993 t.vout[0].nValue = 575;
994 CheckIsNotStandard(t, "dust");
995
996 // Check uncompressed P2PK outputs dust threshold (must have leading 04/06/07)
997 t.vout[0].scriptPubKey = CScript() << std::vector<unsigned char>(65, 0x04) << OP_CHECKSIG;
998 t.vout[0].nValue = 672;
999 CheckIsStandard(t);
1000 t.vout[0].nValue = 671;
1001 CheckIsNotStandard(t, "dust");
1002
1003 // Check P2PKH outputs dust threshold
1004 t.vout[0].scriptPubKey = CScript() << OP_DUP << OP_HASH160 << std::vector<unsigned char>(20, 0) << OP_EQUALVERIFY << OP_CHECKSIG;
1005 t.vout[0].nValue = 546;
1006 CheckIsStandard(t);
1007 t.vout[0].nValue = 545;
1008 CheckIsNotStandard(t, "dust");
1009
1010 // Check P2SH outputs dust threshold
1011 t.vout[0].scriptPubKey = CScript() << OP_HASH160 << std::vector<unsigned char>(20, 0) << OP_EQUAL;
1012 t.vout[0].nValue = 540;
1013 CheckIsStandard(t);
1014 t.vout[0].nValue = 539;
1015 CheckIsNotStandard(t, "dust");
1016
1017 // Check P2WPKH outputs dust threshold
1018 t.vout[0].scriptPubKey = CScript() << OP_0 << std::vector<unsigned char>(20, 0);
1019 t.vout[0].nValue = 294;
1020 CheckIsStandard(t);
1021 t.vout[0].nValue = 293;
1022 CheckIsNotStandard(t, "dust");
1023
1024 // Check P2WSH outputs dust threshold
1025 t.vout[0].scriptPubKey = CScript() << OP_0 << std::vector<unsigned char>(32, 0);
1026 t.vout[0].nValue = 330;
1027 CheckIsStandard(t);
1028 t.vout[0].nValue = 329;
1029 CheckIsNotStandard(t, "dust");
1030
1031 // Check P2TR outputs dust threshold (Invalid xonly key ok!)
1032 t.vout[0].scriptPubKey = CScript() << OP_1 << std::vector<unsigned char>(32, 0);
1033 t.vout[0].nValue = 330;
1034 CheckIsStandard(t);
1035 t.vout[0].nValue = 329;
1036 CheckIsNotStandard(t, "dust");
1037
1038 // Check future Witness Program versions dust threshold (non-32-byte pushes are undefined for version 1)
1039 for (int op = OP_1; op <= OP_16; op += 1) {
1040 t.vout[0].scriptPubKey = CScript() << (opcodetype)op << std::vector<unsigned char>(2, 0);
1041 t.vout[0].nValue = 240;
1042 CheckIsStandard(t);
1043
1044 t.vout[0].nValue = 239;
1045 CheckIsNotStandard(t, "dust");
1046 }
1047
1048 // Check anchor outputs
1049 t.vout[0].scriptPubKey = CScript() << OP_1 << ANCHOR_BYTES;
1050 BOOST_CHECK(t.vout[0].scriptPubKey.IsPayToAnchor());
1051 t.vout[0].nValue = 240;
1052 CheckIsStandard(t);
1053 t.vout[0].nValue = 239;
1054 CheckIsNotStandard(t, "dust");
1055}
1056
1057BOOST_AUTO_TEST_CASE(max_standard_legacy_sigops)
1058{
1059 CCoinsView coins_dummy;
1060 CCoinsViewCache coins(&coins_dummy);
1061 CKey key;
1062 key.MakeNewKey(true);
1063
1064 // Create a pathological P2SH script padded with as many sigops as is standard.
1065 CScript max_sigops_redeem_script{CScript() << std::vector<unsigned char>{} << key.GetPubKey()};
1066 for (unsigned i{0}; i < MAX_P2SH_SIGOPS - 1; ++i) max_sigops_redeem_script << OP_2DUP << OP_CHECKSIG << OP_DROP;
1067 max_sigops_redeem_script << OP_CHECKSIG << OP_NOT;
1068 const CScript max_sigops_p2sh{GetScriptForDestination(ScriptHash(max_sigops_redeem_script))};
1069
1070 // Create a transaction fanning out as many such P2SH outputs as is standard to spend in a
1071 // single transaction, and a transaction spending them.
1072 CMutableTransaction tx_create, tx_max_sigops;
1073 const unsigned p2sh_inputs_count{MAX_TX_LEGACY_SIGOPS / MAX_P2SH_SIGOPS};
1074 tx_create.vout.reserve(p2sh_inputs_count);
1075 for (unsigned i{0}; i < p2sh_inputs_count; ++i) {
1076 tx_create.vout.emplace_back(424242 + i, max_sigops_p2sh);
1077 }
1078 auto prev_txid{tx_create.GetHash()};
1079 tx_max_sigops.vin.reserve(p2sh_inputs_count);
1080 for (unsigned i{0}; i < p2sh_inputs_count; ++i) {
1081 tx_max_sigops.vin.emplace_back(prev_txid, i, CScript() << ToByteVector(max_sigops_redeem_script));
1082 }
1083
1084 // p2sh_inputs_count is truncated to 166 (from 166.6666..)
1085 BOOST_CHECK_LT(p2sh_inputs_count * MAX_P2SH_SIGOPS, MAX_TX_LEGACY_SIGOPS);
1086 AddCoins(coins, CTransaction(tx_create), 0, false);
1087
1088 // 2490 sigops is below the limit.
1089 BOOST_CHECK_EQUAL(GetP2SHSigOpCount(CTransaction(tx_max_sigops), coins), 2490);
1090 BOOST_CHECK(::AreInputsStandard(CTransaction(tx_max_sigops), coins));
1091
1092 // Adding one more input will bump this to 2505, hitting the limit.
1093 tx_create.vout.emplace_back(424242, max_sigops_p2sh);
1094 prev_txid = tx_create.GetHash();
1095 for (unsigned i{0}; i < p2sh_inputs_count; ++i) {
1096 tx_max_sigops.vin[i] = CTxIn(COutPoint(prev_txid, i), CScript() << ToByteVector(max_sigops_redeem_script));
1097 }
1098 tx_max_sigops.vin.emplace_back(prev_txid, p2sh_inputs_count, CScript() << ToByteVector(max_sigops_redeem_script));
1099 AddCoins(coins, CTransaction(tx_create), 0, false);
1100 BOOST_CHECK_GT((p2sh_inputs_count + 1) * MAX_P2SH_SIGOPS, MAX_TX_LEGACY_SIGOPS);
1101 BOOST_CHECK_EQUAL(GetP2SHSigOpCount(CTransaction(tx_max_sigops), coins), 2505);
1102 BOOST_CHECK(!::AreInputsStandard(CTransaction(tx_max_sigops), coins));
1103
1104 // Now, check the limit can be reached with regular P2PK outputs too. Use a separate
1105 // preparation transaction, to demonstrate spending coins from a single tx is irrelevant.
1106 CMutableTransaction tx_create_p2pk;
1107 const auto p2pk_script{CScript() << key.GetPubKey() << OP_CHECKSIG};
1108 unsigned p2pk_inputs_count{10}; // From 2490 to 2500.
1109 for (unsigned i{0}; i < p2pk_inputs_count; ++i) {
1110 tx_create_p2pk.vout.emplace_back(212121 + i, p2pk_script);
1111 }
1112 prev_txid = tx_create_p2pk.GetHash();
1113 tx_max_sigops.vin.resize(p2sh_inputs_count); // Drop the extra input.
1114 for (unsigned i{0}; i < p2pk_inputs_count; ++i) {
1115 tx_max_sigops.vin.emplace_back(prev_txid, i);
1116 }
1117 AddCoins(coins, CTransaction(tx_create_p2pk), 0, false);
1118
1119 // The transaction now contains exactly 2500 sigops, the check should pass.
1120 BOOST_CHECK_EQUAL(p2sh_inputs_count * MAX_P2SH_SIGOPS + p2pk_inputs_count * 1, MAX_TX_LEGACY_SIGOPS);
1121 BOOST_CHECK(::AreInputsStandard(CTransaction(tx_max_sigops), coins));
1122
1123 // Now, add some Segwit inputs. We add one for each defined Segwit output type. The limit
1124 // is exclusively on non-witness sigops and therefore those should not be counted.
1125 CMutableTransaction tx_create_segwit;
1126 const auto witness_script{CScript() << key.GetPubKey() << OP_CHECKSIG};
1127 tx_create_segwit.vout.emplace_back(121212, GetScriptForDestination(WitnessV0KeyHash(key.GetPubKey())));
1128 tx_create_segwit.vout.emplace_back(131313, GetScriptForDestination(WitnessV0ScriptHash(witness_script)));
1129 tx_create_segwit.vout.emplace_back(141414, GetScriptForDestination(WitnessV1Taproot{XOnlyPubKey(key.GetPubKey())}));
1130 prev_txid = tx_create_segwit.GetHash();
1131 for (unsigned i{0}; i < tx_create_segwit.vout.size(); ++i) {
1132 tx_max_sigops.vin.emplace_back(prev_txid, i);
1133 }
1134
1135 // The transaction now still contains exactly 2500 sigops, the check should pass.
1136 AddCoins(coins, CTransaction(tx_create_segwit), 0, false);
1137 BOOST_REQUIRE(::AreInputsStandard(CTransaction(tx_max_sigops), coins));
1138
1139 // Add one more P2PK input. We'll reach the limit.
1140 tx_create_p2pk.vout.emplace_back(212121, p2pk_script);
1141 prev_txid = tx_create_p2pk.GetHash();
1142 tx_max_sigops.vin.resize(p2sh_inputs_count);
1143 ++p2pk_inputs_count;
1144 for (unsigned i{0}; i < p2pk_inputs_count; ++i) {
1145 tx_max_sigops.vin.emplace_back(prev_txid, i);
1146 }
1147 AddCoins(coins, CTransaction(tx_create_p2pk), 0, false);
1148 BOOST_CHECK_GT(p2sh_inputs_count * MAX_P2SH_SIGOPS + p2pk_inputs_count * 1, MAX_TX_LEGACY_SIGOPS);
1149 BOOST_CHECK(!::AreInputsStandard(CTransaction(tx_max_sigops), coins));
1150}
1151
1153BOOST_AUTO_TEST_CASE(spends_witness_prog)
1154{
1155 CCoinsView coins_dummy;
1156 CCoinsViewCache coins(&coins_dummy);
1157 CKey key;
1158 key.MakeNewKey(true);
1159 const CPubKey pubkey{key.GetPubKey()};
1160 CMutableTransaction tx_create{}, tx_spend{};
1161 tx_create.vout.emplace_back(0, CScript{});
1162 tx_spend.vin.emplace_back(Txid{}, 0);
1163 std::vector<std::vector<uint8_t>> sol_dummy;
1164
1165 // CNoDestination, PubKeyDestination, PKHash, ScriptHash, WitnessV0ScriptHash, WitnessV0KeyHash,
1166 // WitnessV1Taproot, PayToAnchor, WitnessUnknown.
1167 static_assert(std::variant_size_v<CTxDestination> == 9);
1168
1169 // Go through all defined output types and sanity check SpendsNonAnchorWitnessProg.
1170
1171 // P2PK
1172 tx_create.vout[0].scriptPubKey = GetScriptForDestination(PubKeyDestination{pubkey});
1173 BOOST_CHECK_EQUAL(Solver(tx_create.vout[0].scriptPubKey, sol_dummy), TxoutType::PUBKEY);
1174 tx_spend.vin[0].prevout.hash = tx_create.GetHash();
1175 AddCoins(coins, CTransaction{tx_create}, 0, false);
1177
1178 // P2PKH
1179 tx_create.vout[0].scriptPubKey = GetScriptForDestination(PKHash{pubkey});
1180 BOOST_CHECK_EQUAL(Solver(tx_create.vout[0].scriptPubKey, sol_dummy), TxoutType::PUBKEYHASH);
1181 tx_spend.vin[0].prevout.hash = tx_create.GetHash();
1182 AddCoins(coins, CTransaction{tx_create}, 0, false);
1184
1185 // P2SH
1186 auto redeem_script{CScript{} << OP_1 << OP_CHECKSIG};
1187 tx_create.vout[0].scriptPubKey = GetScriptForDestination(ScriptHash{redeem_script});
1188 BOOST_CHECK_EQUAL(Solver(tx_create.vout[0].scriptPubKey, sol_dummy), TxoutType::SCRIPTHASH);
1189 tx_spend.vin[0].prevout.hash = tx_create.GetHash();
1190 tx_spend.vin[0].scriptSig = CScript{} << OP_0 << ToByteVector(redeem_script);
1191 AddCoins(coins, CTransaction{tx_create}, 0, false);
1193 tx_spend.vin[0].scriptSig.clear();
1194
1195 // native P2WSH
1196 const auto witness_script{CScript{} << OP_12 << OP_HASH160 << OP_DUP << OP_EQUAL};
1197 tx_create.vout[0].scriptPubKey = GetScriptForDestination(WitnessV0ScriptHash{witness_script});
1198 BOOST_CHECK_EQUAL(Solver(tx_create.vout[0].scriptPubKey, sol_dummy), TxoutType::WITNESS_V0_SCRIPTHASH);
1199 tx_spend.vin[0].prevout.hash = tx_create.GetHash();
1200 AddCoins(coins, CTransaction{tx_create}, 0, false);
1202
1203 // P2SH-wrapped P2WSH
1204 redeem_script = tx_create.vout[0].scriptPubKey;
1205 tx_create.vout[0].scriptPubKey = GetScriptForDestination(ScriptHash(redeem_script));
1206 BOOST_CHECK_EQUAL(Solver(tx_create.vout[0].scriptPubKey, sol_dummy), TxoutType::SCRIPTHASH);
1207 tx_spend.vin[0].prevout.hash = tx_create.GetHash();
1208 tx_spend.vin[0].scriptSig = CScript{} << ToByteVector(redeem_script);
1209 AddCoins(coins, CTransaction{tx_create}, 0, false);
1211 tx_spend.vin[0].scriptSig.clear();
1213
1214 // native P2WPKH
1215 tx_create.vout[0].scriptPubKey = GetScriptForDestination(WitnessV0KeyHash{pubkey});
1216 BOOST_CHECK_EQUAL(Solver(tx_create.vout[0].scriptPubKey, sol_dummy), TxoutType::WITNESS_V0_KEYHASH);
1217 tx_spend.vin[0].prevout.hash = tx_create.GetHash();
1218 AddCoins(coins, CTransaction{tx_create}, 0, false);
1220
1221 // P2SH-wrapped P2WPKH
1222 redeem_script = tx_create.vout[0].scriptPubKey;
1223 tx_create.vout[0].scriptPubKey = GetScriptForDestination(ScriptHash(redeem_script));
1224 BOOST_CHECK_EQUAL(Solver(tx_create.vout[0].scriptPubKey, sol_dummy), TxoutType::SCRIPTHASH);
1225 tx_spend.vin[0].prevout.hash = tx_create.GetHash();
1226 tx_spend.vin[0].scriptSig = CScript{} << ToByteVector(redeem_script);
1227 AddCoins(coins, CTransaction{tx_create}, 0, false);
1229 tx_spend.vin[0].scriptSig.clear();
1231
1232 // P2TR
1233 tx_create.vout[0].scriptPubKey = GetScriptForDestination(WitnessV1Taproot{XOnlyPubKey{pubkey}});
1234 BOOST_CHECK_EQUAL(Solver(tx_create.vout[0].scriptPubKey, sol_dummy), TxoutType::WITNESS_V1_TAPROOT);
1235 tx_spend.vin[0].prevout.hash = tx_create.GetHash();
1236 AddCoins(coins, CTransaction{tx_create}, 0, false);
1238
1239 // P2SH-wrapped P2TR (undefined, non-standard)
1240 redeem_script = tx_create.vout[0].scriptPubKey;
1241 tx_create.vout[0].scriptPubKey = GetScriptForDestination(ScriptHash(redeem_script));
1242 BOOST_CHECK_EQUAL(Solver(tx_create.vout[0].scriptPubKey, sol_dummy), TxoutType::SCRIPTHASH);
1243 tx_spend.vin[0].prevout.hash = tx_create.GetHash();
1244 tx_spend.vin[0].scriptSig = CScript{} << ToByteVector(redeem_script);
1245 AddCoins(coins, CTransaction{tx_create}, 0, false);
1247 tx_spend.vin[0].scriptSig.clear();
1249
1250 // P2A
1251 tx_create.vout[0].scriptPubKey = GetScriptForDestination(PayToAnchor{});
1252 BOOST_CHECK_EQUAL(Solver(tx_create.vout[0].scriptPubKey, sol_dummy), TxoutType::ANCHOR);
1253 tx_spend.vin[0].prevout.hash = tx_create.GetHash();
1254 AddCoins(coins, CTransaction{tx_create}, 0, false);
1256
1257 // P2SH-wrapped P2A (undefined, non-standard)
1258 redeem_script = tx_create.vout[0].scriptPubKey;
1259 tx_create.vout[0].scriptPubKey = GetScriptForDestination(ScriptHash(redeem_script));
1260 BOOST_CHECK_EQUAL(Solver(tx_create.vout[0].scriptPubKey, sol_dummy), TxoutType::SCRIPTHASH);
1261 tx_spend.vin[0].prevout.hash = tx_create.GetHash();
1262 tx_spend.vin[0].scriptSig = CScript{} << ToByteVector(redeem_script);
1263 AddCoins(coins, CTransaction{tx_create}, 0, false);
1265 tx_spend.vin[0].scriptSig.clear();
1266
1267 // Undefined version 1 witness program
1268 tx_create.vout[0].scriptPubKey = GetScriptForDestination(WitnessUnknown{1, {0x42, 0x42}});
1269 BOOST_CHECK_EQUAL(Solver(tx_create.vout[0].scriptPubKey, sol_dummy), TxoutType::WITNESS_UNKNOWN);
1270 tx_spend.vin[0].prevout.hash = tx_create.GetHash();
1271 AddCoins(coins, CTransaction{tx_create}, 0, false);
1273
1274 // P2SH-wrapped undefined version 1 witness program
1275 redeem_script = tx_create.vout[0].scriptPubKey;
1276 tx_create.vout[0].scriptPubKey = GetScriptForDestination(ScriptHash(redeem_script));
1277 BOOST_CHECK_EQUAL(Solver(tx_create.vout[0].scriptPubKey, sol_dummy), TxoutType::SCRIPTHASH);
1278 tx_spend.vin[0].prevout.hash = tx_create.GetHash();
1279 tx_spend.vin[0].scriptSig = CScript{} << ToByteVector(redeem_script);
1280 AddCoins(coins, CTransaction{tx_create}, 0, false);
1282 tx_spend.vin[0].scriptSig.clear();
1284
1285 // Various undefined version >1 32-byte witness programs.
1286 const auto program{ToByteVector(XOnlyPubKey{pubkey})};
1287 for (int i{2}; i <= 16; ++i) {
1288 tx_create.vout[0].scriptPubKey = GetScriptForDestination(WitnessUnknown{i, program});
1289 BOOST_CHECK_EQUAL(Solver(tx_create.vout[0].scriptPubKey, sol_dummy), TxoutType::WITNESS_UNKNOWN);
1290 tx_spend.vin[0].prevout.hash = tx_create.GetHash();
1291 AddCoins(coins, CTransaction{tx_create}, 0, false);
1293
1294 // It's also detected within P2SH.
1295 redeem_script = tx_create.vout[0].scriptPubKey;
1296 tx_create.vout[0].scriptPubKey = GetScriptForDestination(ScriptHash(redeem_script));
1297 BOOST_CHECK_EQUAL(Solver(tx_create.vout[0].scriptPubKey, sol_dummy), TxoutType::SCRIPTHASH);
1298 tx_spend.vin[0].prevout.hash = tx_create.GetHash();
1299 tx_spend.vin[0].scriptSig = CScript{} << ToByteVector(redeem_script);
1300 AddCoins(coins, CTransaction{tx_create}, 0, false);
1302 tx_spend.vin[0].scriptSig.clear();
1304 }
1305}
1306
std::vector< unsigned char > valtype
Definition: addresstype.cpp:18
CScript GetScriptForDestination(const CTxDestination &dest)
Generate a Bitcoin scriptPubKey for the given CTxDestination.
static const std::vector< unsigned char > ANCHOR_BYTES
Witness program for Pay-to-Anchor output script type.
Definition: addresstype.h:121
static constexpr CAmount MAX_MONEY
No amount larger than this (in satoshi) is valid.
Definition: amount.h:26
int64_t CAmount
Amount in satoshis (Can be negative)
Definition: amount.h:12
int ret
int flags
Definition: bitcoin-tx.cpp:529
#define Assert(val)
Identity function.
Definition: check.h:106
RAII-style controller object for a CCheckQueue that guarantees the passed queue is finished before co...
Definition: checkqueue.h:209
std::optional< R > Complete()
Definition: checkqueue.h:221
void Add(std::vector< T > &&vChecks)
Definition: checkqueue.h:228
CCoinsView that adds a memory cache for transactions to another CCoinsView.
Definition: coins.h:363
Abstract view on the open txout dataset.
Definition: coins.h:310
Fee rate in satoshis per virtualbyte: CAmount / vB the feerate is represented internally as FeeFrac.
Definition: feerate.h:35
CAmount GetFeePerK() const
Return the fee in satoshis for a vsize of 1000 vbytes.
Definition: feerate.h:63
An encapsulated private key.
Definition: key.h:35
void MakeNewKey(bool fCompressed)
Generate a new private key using a cryptographic PRNG.
Definition: key.cpp:161
CPubKey GetPubKey() const
Compute the public key from a private key.
Definition: key.cpp:182
A reference to a CKey: the Hash160 of its serialized public key.
Definition: pubkey.h:24
An outpoint - a combination of a transaction hash and an index n into its vout.
Definition: transaction.h:29
An encapsulated public key.
Definition: pubkey.h:34
CKeyID GetID() const
Get the KeyID of this public key (hash of its serialization)
Definition: pubkey.h:164
Serialized script, used inside transaction inputs and outputs.
Definition: script.h:413
static opcodetype EncodeOP_N(int n)
Definition: script.h:522
The basic transaction that is broadcasted on the network and contained in blocks.
Definition: transaction.h:296
const std::vector< CTxOut > vout
Definition: transaction.h:307
const std::vector< CTxIn > vin
Definition: transaction.h:306
An input of a transaction.
Definition: transaction.h:67
CScript scriptSig
Definition: transaction.h:70
CScriptWitness scriptWitness
Only serialized through CTransaction.
Definition: transaction.h:72
COutPoint prevout
Definition: transaction.h:69
CScript scriptPubKey
Definition: transaction.h:153
CAmount nValue
Definition: transaction.h:152
A UTXO entry.
Definition: coins.h:33
CTxOut out
unspent transaction output
Definition: coins.h:36
uint32_t nHeight
at which height this containing transaction was included in the active block chain
Definition: coins.h:42
unsigned int fCoinBase
whether containing transaction was a coinbase
Definition: coins.h:39
Double ended buffer combining vector and stream-like interfaces.
Definition: streams.h:130
Fillable signing provider that keeps keys in an address->secret map.
virtual bool AddKeyPubKey(const CKey &key, const CPubKey &pubkey)
virtual bool AddCScript(const CScript &redeemScript)
A signature creator for transactions.
Definition: sign.h:40
Valid signature cache, to avoid doing expensive ECDSA signature checking twice for every transaction ...
Definition: sigcache.h:39
const std::string & get_str() const
bool isArray() const
Definition: univalue.h:87
std::string write(unsigned int prettyIndent=0, unsigned int indentLevel=0) const
size_t size() const
Definition: univalue.h:71
bool isStr() const
Definition: univalue.h:85
Int getInt() const
Definition: univalue.h:140
const UniValue & get_array() const
bool IsValid() const
Definition: validation.h:105
std::string GetRejectReason() const
Definition: validation.h:109
bool IsInvalid() const
Definition: validation.h:106
constexpr unsigned char * end()
Definition: uint256.h:102
constexpr unsigned char * begin()
Definition: uint256.h:101
void emplace_back(Args &&... args)
Definition: prevector.h:391
iterator begin()
Definition: prevector.h:263
iterator end()
Definition: prevector.h:265
static std::optional< transaction_identifier > FromHex(std::string_view hex)
void AddCoins(CCoinsViewCache &cache, const CTransaction &tx, int nHeight, bool check_for_overwrite)
Utility function to add all of a transaction's outputs to a cache.
Definition: coins.cpp:119
static int32_t GetTransactionWeight(const CTransaction &tx)
Definition: validation.h:132
static const unsigned int MAX_BLOCK_WEIGHT
The maximum allowed weight for a block, see BIP 141 (network rule)
Definition: consensus.h:15
static const int WITNESS_SCALE_FACTOR
Definition: consensus.h:21
CScript ParseScript(const std::string &s)
Definition: core_read.cpp:63
BOOST_FIXTURE_TEST_SUITE(cuckoocache_tests, BasicTestingSetup)
Test Suite for CuckooCache.
BOOST_AUTO_TEST_SUITE_END()
bool EvalScript(std::vector< std::vector< unsigned char > > &stack, const CScript &script, unsigned int flags, const BaseSignatureChecker &checker, SigVersion sigversion, ScriptExecutionData &execdata, ScriptError *serror)
bool VerifyScript(const CScript &scriptSig, const CScript &scriptPubKey, const CScriptWitness *witness, unsigned int flags, const BaseSignatureChecker &checker, ScriptError *serror)
@ BASE
Bare scripts and BIP16 P2SH-wrapped redeemscripts.
@ SCRIPT_VERIFY_NULLDUMMY
Definition: interpreter.h:64
@ SCRIPT_VERIFY_P2SH
Definition: interpreter.h:49
@ SCRIPT_VERIFY_SIGPUSHONLY
Definition: interpreter.h:67
@ SCRIPT_VERIFY_DISCOURAGE_OP_SUCCESS
Definition: interpreter.h:141
@ SCRIPT_VERIFY_WITNESS
Definition: interpreter.h:108
@ SCRIPT_VERIFY_CONST_SCRIPTCODE
Definition: interpreter.h:130
@ SCRIPT_VERIFY_MINIMALIF
Definition: interpreter.h:118
@ SCRIPT_VERIFY_LOW_S
Definition: interpreter.h:61
@ SCRIPT_VERIFY_CHECKLOCKTIMEVERIFY
Definition: interpreter.h:99
@ SCRIPT_VERIFY_WITNESS_PUBKEYTYPE
Definition: interpreter.h:126
@ SCRIPT_VERIFY_DISCOURAGE_UPGRADABLE_TAPROOT_VERSION
Definition: interpreter.h:138
@ SCRIPT_VERIFY_TAPROOT
Definition: interpreter.h:134
@ SCRIPT_VERIFY_STRICTENC
Definition: interpreter.h:54
@ SCRIPT_VERIFY_NULLFAIL
Definition: interpreter.h:122
@ SCRIPT_VERIFY_DERSIG
Definition: interpreter.h:57
@ SCRIPT_VERIFY_DISCOURAGE_UPGRADABLE_PUBKEYTYPE
Definition: interpreter.h:144
@ SCRIPT_VERIFY_CLEANSTACK
Definition: interpreter.h:94
@ SCRIPT_VERIFY_NONE
Definition: interpreter.h:46
@ SCRIPT_VERIFY_MINIMALDATA
Definition: interpreter.h:73
@ SCRIPT_VERIFY_DISCOURAGE_UPGRADABLE_NOPS
Definition: interpreter.h:85
@ SCRIPT_VERIFY_CHECKSEQUENCEVERIFY
Definition: interpreter.h:104
@ SCRIPT_VERIFY_DISCOURAGE_UPGRADABLE_WITNESS_PROGRAM
Definition: interpreter.h:112
@ SIGHASH_ANYONECANPAY
Definition: interpreter.h:33
@ SIGHASH_ALL
Definition: interpreter.h:30
@ SIGHASH_NONE
Definition: interpreter.h:31
@ SIGHASH_SINGLE
Definition: interpreter.h:32
@ ASSERT_FAIL
Abort execution through assertion failure (for consensus code)
UniValue read_json(std::string_view jsondata)
Definition: json.cpp:12
CKey GenerateRandomKey(bool compressed) noexcept
Definition: key.cpp:352
""_hex is a compile-time user-defined literal returning a std::array<std::byte>, equivalent to ParseH...
Definition: strencodings.h:384
std::vector< std::string > SplitString(std::string_view str, char sep)
Definition: string.h:148
std::string ToString(const T &t)
Locale-independent version of std::to_string.
Definition: string.h:245
#define BOOST_CHECK_EQUAL(v1, v2)
Definition: object.cpp:18
#define BOOST_CHECK(expr)
Definition: object.cpp:17
bool SpendsNonAnchorWitnessProg(const CTransaction &tx, const CCoinsViewCache &prevouts)
Check whether this transaction spends any witness program but P2A, including not-yet-defined ones.
Definition: policy.cpp:340
bool AreInputsStandard(const CTransaction &tx, const CCoinsViewCache &mapInputs)
Check transaction inputs.
Definition: policy.cpp:213
bool IsStandardTx(const CTransaction &tx, const std::optional< unsigned > &max_datacarrier_bytes, bool permit_bare_multisig, const CFeeRate &dust_relay_fee, std::string &reason)
Check for standard transaction types.
Definition: policy.cpp:99
static const unsigned int MAX_OP_RETURN_RELAY
Default setting for -datacarriersize in vbytes.
Definition: policy.h:80
static constexpr unsigned int MAX_TX_LEGACY_SIGOPS
The maximum number of potentially executed legacy signature operations in a single standard tx.
Definition: policy.h:42
static constexpr decltype(CTransaction::version) TX_MAX_STANDARD_VERSION
Definition: policy.h:149
static constexpr bool DEFAULT_PERMIT_BAREMULTISIG
Default for -permitbaremultisig.
Definition: policy.h:48
static constexpr unsigned int DUST_RELAY_TX_FEE
Min feerate for defining dust.
Definition: policy.h:64
static constexpr unsigned int MAX_DUST_OUTPUTS_PER_TX
Maximum number of ephemeral dust outputs allowed.
Definition: policy.h:91
static constexpr unsigned int STANDARD_SCRIPT_VERIFY_FLAGS
Standard script verification flags that standard transactions will comply with.
Definition: policy.h:115
static constexpr unsigned int MAX_P2SH_SIGOPS
Maximum number of signature check operations in an IsStandard() P2SH script.
Definition: policy.h:38
static constexpr TransactionSerParams TX_NO_WITNESS
Definition: transaction.h:196
static constexpr TransactionSerParams TX_WITH_WITNESS
Definition: transaction.h:195
std::shared_ptr< const CTransaction > CTransactionRef
Definition: transaction.h:423
const char * name
Definition: rest.cpp:50
opcodetype
Script opcodes.
Definition: script.h:74
@ OP_PUSHDATA4
Definition: script.h:80
@ OP_IF
Definition: script.h:104
@ OP_ROT
Definition: script.h:130
@ OP_1NEGATE
Definition: script.h:81
@ OP_CHECKSIG
Definition: script.h:190
@ OP_CHECKLOCKTIMEVERIFY
Definition: script.h:197
@ OP_16
Definition: script.h:99
@ OP_NOT
Definition: script.h:158
@ OP_EQUAL
Definition: script.h:146
@ OP_SIZE
Definition: script.h:139
@ OP_3DUP
Definition: script.h:118
@ OP_DUP
Definition: script.h:125
@ OP_NOP
Definition: script.h:102
@ OP_CODESEPARATOR
Definition: script.h:189
@ OP_HASH256
Definition: script.h:188
@ OP_SUB
Definition: script.h:162
@ OP_HASH160
Definition: script.h:187
@ OP_2DUP
Definition: script.h:117
@ OP_1
Definition: script.h:83
@ OP_TRUE
Definition: script.h:84
@ OP_VERIFY
Definition: script.h:110
@ OP_12
Definition: script.h:95
@ OP_ADD
Definition: script.h:161
@ OP_DROP
Definition: script.h:124
@ OP_9
Definition: script.h:92
@ OP_0
Definition: script.h:76
@ OP_RETURN
Definition: script.h:111
@ OP_EQUALVERIFY
Definition: script.h:147
@ OP_RESERVED
Definition: script.h:82
std::vector< unsigned char > ToByteVector(const T &in)
Definition: script.h:67
std::string ScriptErrorString(const ScriptError serror)
enum ScriptError_t ScriptError
@ SCRIPT_ERR_UNKNOWN_ERROR
Definition: script_error.h:14
@ SCRIPT_ERR_OK
Definition: script_error.h:13
static const int64_t values[]
A selection of numbers that do not trigger int64_t overflow when added/subtracted.
size_t GetSerializeSize(const T &t)
Definition: serialize.h:1094
constexpr deserialize_type deserialize
Definition: serialize.h:49
static constexpr CAmount CENT
Definition: setup_common.h:47
static constexpr size_t DEFAULT_SIGNATURE_CACHE_BYTES
Definition: sigcache.h:29
bool ProduceSignature(const SigningProvider &provider, const BaseSignatureCreator &creator, const CScript &fromPubKey, SignatureData &sigdata)
Produce a script signature using a generic signature creator.
Definition: sign.cpp:502
void UpdateInput(CTxIn &input, const SignatureData &data)
Definition: sign.cpp:675
SignatureData DataFromTransaction(const CMutableTransaction &tx, unsigned int nIn, const CTxOut &txout)
Extract signature data from a transaction input, and insert it.
Definition: sign.cpp:610
const SigningProvider & DUMMY_SIGNING_PROVIDER
TxoutType Solver(const CScript &scriptPubKey, std::vector< std::vector< unsigned char > > &vSolutionsRet)
Parse a scriptPubKey and identify script type for standard scripts.
Definition: solver.cpp:141
CScript GetScriptForMultisig(int nRequired, const std::vector< CPubKey > &keys)
Generate a multisig script.
Definition: solver.cpp:218
@ WITNESS_V1_TAPROOT
@ WITNESS_UNKNOWN
Only for Witness versions not already defined above.
@ ANCHOR
anyone can spend script
@ WITNESS_V0_SCRIPTHASH
@ WITNESS_V0_KEYHASH
std::vector< Byte > ParseHex(std::string_view hex_str)
Like TryParseHex, but returns an empty vector on invalid input.
Definition: strencodings.h:68
Basic testing setup.
Definition: setup_common.h:64
A mutable version of CTransaction.
Definition: transaction.h:378
std::vector< CTxOut > vout
Definition: transaction.h:380
Txid GetHash() const
Compute the hash of this CMutableTransaction.
Definition: transaction.cpp:69
std::vector< CTxIn > vin
Definition: transaction.h:379
void MergeSignatureData(SignatureData sigdata)
Definition: sign.cpp:681
CTxDestination subtype to encode any future Witness version.
Definition: addresstype.h:96
bool IsValidFlagCombination(unsigned flags)
Flags that are not forbidden by an assert in script validation.
Definition: script.cpp:8
SignatureData CombineSignatures(const CMutableTransaction &input1, const CMutableTransaction &input2, const CTransactionRef tx)
static void CheckWithFlag(const CTransactionRef &output, const CMutableTransaction &input, uint32_t flags, bool success)
std::set< unsigned int > ExcludeIndividualFlags(unsigned int flags)
static bool g_bare_multi
unsigned int FillFlags(unsigned int flags)
std::vector< unsigned char > valtype
BOOST_AUTO_TEST_CASE(tx_valid)
unsigned int ParseScriptFlags(std::string strFlags)
static void ReplaceRedeemScript(CScript &script, const CScript &redeemScript)
bool CheckMapFlagNames()
std::string FormatScriptFlags(unsigned int flags)
static void CreateCreditAndSpend(const FillableSigningProvider &keystore, const CScript &outscript, CTransactionRef &output, CMutableTransaction &input, bool success=true)
static CScript PushAll(const std::vector< valtype > &values)
static std::map< std::string, unsigned int > mapFlagNames
static CFeeRate g_dust
bool CheckTxScripts(const CTransaction &tx, const std::map< COutPoint, CScript > &map_prevout_scriptPubKeys, const std::map< COutPoint, int64_t > &map_prevout_values, unsigned int flags, const PrecomputedTransactionData &txdata, const std::string &strTest, bool expect_valid)
unsigned int TrimFlags(unsigned int flags)
std::vector< CMutableTransaction > SetupDummyInputs(FillableSigningProvider &keystoreRet, CCoinsViewCache &coinsRet, const std::array< CAmount, 4 > &nValues)
bool SignSignature(const SigningProvider &provider, const CScript &fromPubKey, CMutableTransaction &txTo, unsigned int nIn, const CAmount &amount, int nHashType, SignatureData &sig_data)
Produce a satisfying script (scriptSig or witness).
bool CheckTransaction(const CTransaction &tx, TxValidationState &state)
Definition: tx_check.cpp:11
unsigned int GetP2SHSigOpCount(const CTransaction &tx, const CCoinsViewCache &inputs)
Count ECDSA signature operations in pay-to-script-hash inputs.
Definition: tx_verify.cpp:126
constexpr std::array tests
Definition: unitester.cpp:100
assert(!tx.IsCoinBase())